Pass -H:+UnlockExperimentalVMOptions as necessary with Graalvm 23.1 #35379
Conversation
|
@zakkak which versions of Quarkus are using 23.1? Should it be backported? |
None yet, 23.1 (or GraalVM for JDK 21) is still in development and planned to be released mid-September
No |
|
Cancelling CI for now as it is saturated. I will restart this later. |
Needed since oracle/graal#7190 to avoid warnings
0e6ef31 to
1a1d4ea
Compare
| private void addExperimentalVMOption(List<String> nativeImageArgs, String option) { | ||
| if (graalVMVersion.compareTo(GraalVM.Version.VERSION_23_1_0) >= 0) { | ||
| nativeImageArgs.add("-H:+UnlockExperimentalVMOptions"); | ||
| } | ||
| nativeImageArgs.add(option); | ||
| if (graalVMVersion.compareTo(GraalVM.Version.VERSION_23_1_0) >= 0) { | ||
| nativeImageArgs.add("-H:-UnlockExperimentalVMOptions"); | ||
| } |
There was a problem hiding this comment.
So you're surrounding the experimental option with enabling/disabling unlock? Is it really how it works? Never seen something similar :).
There was a problem hiding this comment.
Correct, this is to limit the scope as suggested in oracle/graal#7105 (comment). Alternatively we could just pass -H:+UnlockExperimentalVMOptions as the first option and allow any experimental option to be passed afterwards. It would make things simpler but would also allow people (both Quarkus users and devs) to use experimental options possibly without noticing.
Failing Jobs - Building 1a1d4ea
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: core/deployment
! Skipped: devtools/cli devtools/gradle/gradle-application-plugin devtools/gradle/gradle-extension-plugin and 569 more📦 core/deployment✖ |
Needed since oracle/graal#7190 to avoid warnings
Edit:
The implementation is surrounding the experimental option with enabling/disabling unlock to limit the scope as suggested in oracle/graal#7105 (comment). Alternatively we could just pass -H:+UnlockExperimentalVMOptions as the first option and allow any experimental option to be passed afterwards. It would make things simpler but would also allow people (both Quarkus users and devs) to use experimental options possibly without noticing.