Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.15.0 backports 2 #29713

Merged
merged 28 commits into from
Dec 7, 2022
Merged

2.15.0 backports 2 #29713

merged 28 commits into from
Dec 7, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Dec 6, 2022

Please don't merge, I will merge it myself.

Marcel Lohmann and others added 28 commits December 6, 2022 19:35
Before these changes, we only can disable the hostname verification in Rest Client classic by providing the following property:

```
quarkus.rest-client.extensions-api.hostname-verifier=io.quarkus.restclient.NoopHostnameVerifier
```

However, this is not working in Rest Client reactive because setting a hostname verifier strategy is not supported by the Vert-x HTTP Client.

With these changes, we have added a new property in both Rest Client classic and reactive `quarkus.rest-client.extensions-api.verify-host=true or false`. In Rest Client classic, when disabling the verify host, internally it will add the `NoopHostnameVerifier` strategy. In Rest Client reactive, it will properly configure the Vert.x HTTP client to disable the hostname verification. Therefore, in both Rest Client implementations (classic and reactive), the behaviour is the same.

Fix quarkusio#27901

(cherry picked from commit 941d3a6)
(cherry picked from commit ddc481f)
This adds further details about the fix and the discussion
in quarkusio#29562.
It clearifies that alias is also fine instead of podman-docker,
just redirects the user to podman for install instructions (
they change over time, and more linux variant are shown there,
no need duplicate and maintain), and finally,
it shows a way of running podman as service without
systemd (relevant on wsl up until recently for example,
and users a most likely stuck with slightly older wsl's in a few places).

Signed-off-by: Josef Andersson <josef.andersson@gmail.com>
(cherry picked from commit 9e85d7e)
This annotation allows to actually turn a String into a List<String>
automatically for each query param value

Resolves: quarkusio#29528
(cherry picked from commit f695369)
(cherry picked from commit 6cb6ae7)
Per Andy's request.

(cherry picked from commit f670cfc)
- this is index is mandatory and is used to discover beans
- the computing index is optional and can be used for other tasks, e.g. during type-safe resolution
- if the computing index is not present the immutable index is used
instead
- fixes quarkusio#29575

(cherry picked from commit c2ab342)
(cherry picked from commit 2c3865c)
- make sure that an interface method of an interface-based client proxy
is invoked upon the provider type and not the type that declares the
method
- fixes quarkusio#29593

(cherry picked from commit 4d51083)
@gsmet gsmet added the area/infra internal and infrastructure related issues label Dec 6, 2022
@gsmet gsmet self-assigned this Dec 6, 2022
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/cli Related to quarkus cli (not maven/gradle/etc.) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive area/jbang Issues related to when using jbang.dev with Quarkus area/keycloak area/kubernetes area/maven area/panache area/persistence OBSOLETE, DO NOT USE area/platform Issues related to definition and interaction with Quarkus Platform area/rest area/spring Issues relating to the Spring integration area/tracing area/vertx labels Dec 6, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 7, 2022

Failing Jobs - Building 15c75c5

Status Name Step Failures Logs Raw logs
✔️ Gradle Tests - JDK 11
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
JVM Tests - JDK 18 Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.QuarkusDevDependencyDevModeTest.main line 14 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@gsmet gsmet merged commit 9442d6f into quarkusio:2.15 Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/cli Related to quarkus cli (not maven/gradle/etc.) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive area/infra internal and infrastructure related issues area/jbang Issues related to when using jbang.dev with Quarkus area/keycloak area/kubernetes area/maven area/panache area/persistence OBSOLETE, DO NOT USE area/platform Issues related to definition and interaction with Quarkus Platform area/rest area/spring Issues relating to the Spring integration area/tracing area/vertx
Projects
None yet
Development

Successfully merging this pull request may close these issues.