Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling default ResponseExceptionMapper per REST client #44813

Closed
neon-dev opened this issue Nov 28, 2024 · 5 comments · Fixed by #44816
Closed

Allow disabling default ResponseExceptionMapper per REST client #44813

neon-dev opened this issue Nov 28, 2024 · 5 comments · Fixed by #44816
Labels
area/rest-client kind/enhancement New feature or request
Milestone
3.18.0.CR1

Comments

@neon-dev
Copy link
Contributor

neon-dev commented Nov 28, 2024 •
edited
Loading

Description

microprofile.rest.client.disable.default.mapper=false works on a global level.
It would be useful to have a configuration option that works on a per client basis.
In addition, an annotation could be introduced as a counterpart to the programmatic way.

A new section in the REST cllient docs about it would also be helpful.

Implementation ideas

An annotation could also work at the method level to solve #23957 without introducing unwanted side effects with other methods.
@neon-dev neon-dev added the kind/enhancement New feature or request label Nov 28, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 28, 2024

/cc @cescoffier (rest-client), @geoand (rest-client)

@neon-dev neon-dev mentioned this issue Nov 28, 2024
Closed
@geoand
Copy link
Contributor

geoand commented Nov 28, 2024 •
edited
Loading

If I have time, I'll look into getting this into 3.18 as it is clearly useful

geoand added a commit to geoand/quarkus that referenced this issue Nov 28, 2024
@geoand
Introduce property to disable default mapper per REST Client
4767332 
The default mapper has a very confusing behavior where
it throws an exception HTTP code > 400 even if the
method return type is Response.
This PR means to provide a way so users can disable this mapper
per client instead of globally.

Closes: quarkusio#44813
geoand added a commit to geoand/quarkus that referenced this issue Nov 28, 2024
@geoand
Introduce property to disable default mapper per REST Client
a27c883 
The default mapper has a very confusing behavior where
it throws an exception HTTP code >= 400 even if the
method return type is Response.
This PR means to provide a way so users can disable this mapper
per client instead of globally.

Closes: quarkusio#44813
@geoand geoand mentioned this issue Nov 28, 2024
Merged
geoand added a commit to geoand/quarkus that referenced this issue Nov 28, 2024
@geoand
Introduce property to disable default mapper per REST Client
64ae0fd 
The default mapper has a very confusing behavior where
it throws an exception HTTP code >= 400 even if the
method return type is Response.
This PR means to provide a way so users can disable this mapper
per client instead of globally.

Closes: quarkusio#44813
geoand added a commit to geoand/quarkus that referenced this issue Nov 29, 2024
@geoand
Introduce property to disable default mapper per REST Client
ad3a032 
The default mapper has a very confusing behavior where
it throws an exception HTTP code >= 400 even if the
method return type is Response.
This PR means to provide a way so users can disable this mapper
per client instead of globally.

Closes: quarkusio#44813
geoand added a commit to geoand/quarkus that referenced this issue Nov 29, 2024
@geoand
Introduce property to disable default mapper per REST Client
a16fd1e 
The default mapper has a very confusing behavior where
it throws an exception HTTP code >= 400 even if the
method return type is Response.
This PR means to provide a way so users can disable this mapper
per client instead of globally.

Closes: quarkusio#44813
@geoand
Copy link
Contributor

geoand commented Nov 29, 2024

#44816 adds this functionality

@chonton
Copy link
Contributor

chonton commented Nov 30, 2024

Additional PR for disabling client exception mapper when the proxy method return type is jakarta.ws.rs.core.Response

@geoand geoand closed this as completed in 6ca76ec Dec 2, 2024
geoand added a commit that referenced this issue Dec 2, 2024
@geoand
Merge pull request #44816 from geoand/#44813
c10465e 
Introduce property to disable default mapper per REST Client
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 2, 2024
@geoand
Copy link
Contributor

geoand commented Dec 2, 2024

That's nice, thanks!

alex-pumpkin pushed a commit to alex-pumpkin/quarkus that referenced this issue Dec 2, 2024
@geoand @alex-pumpkin
Introduce property to disable default mapper per REST Client
48dc90c 
The default mapper has a very confusing behavior where
it throws an exception HTTP code >= 400 even if the
method return type is Response.
This PR means to provide a way so users can disable this mapper
per client instead of globally.

Closes: quarkusio#44813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/rest-client kind/enhancement New feature or request
Projects
None yet
Milestone
3.18.0.CR1
Development

Successfully merging a pull request may close this issue.

Introduce property to disable default mapper per REST Client geoand/quarkus
3 participants
@neon-dev @chonton @geoand