-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Spring security guide #37530
Comments
/cc @geoand (spring), @sberyozkin (security) |
@fedinskiy as it seems you already pinpointed the issues, care to open a docs PR fix with the fixes? |
@geoand I will try, but I need guidance on points 4, 5 and 7 |
|
@geoand |
Right, let's go with |
Describe the bug
I went through "Quarkus Extension for Spring Security API" [1] guide and found several issue:
-DnoCode
option is removed. If the option is omitted, the generated code looks a bit differently. Same goes for GreetingControllerTest.mvn clean test
or by pressingr
while in the DevMode.@Secured
annotation and doesn't explain the differences between it and@PreAuthorize
annotation. The link to the Spring documentation will be much appreciated here."hasAnyRole('view1', 'view2') OR isAnonymous() OR hasRole('test')"
. I suppose, we should say, that "expressions do not support parentheses for logical operators and are evaluated from left to right"@Secured
annotation from Spring. We should probably reference this guide[10] to help with replacement of@PreAuthorize
annotation#person.name
format, class Person has to have getName() method and remove "or field of the parameter" from the description (fields, even public, can not be used for this check)@Override
annotation on a method, which is not inherited, it can probably be deleted.[1] https://quarkus.io/version/main/guides/spring-security
[2] https://quarkus.io/version/main/guides/spring-security#greetingcontroller
[3] https://quarkus.io/version/main/guides/spring-security#creating-the-maven-project
[4] https://quarkus.io/version/main/guides/spring-security#greetingcontrollertest-2
[5] https://quarkus.io/version/main/guides/spring-security#test-the-changes
[6] https://quarkus.io/version/main/guides/spring-security#run-the-application-as-a-native-executable
[7] https://quarkus.io/guides/building-native-image
[8] https://quarkus.io/version/main/guides/spring-security#combining-expressions
[9] https://quarkus.io/version/main/guides/spring-security#conversion-table
[10] https://quarkus.io/guides/security-authorize-web-endpoints-reference
Expected behavior
No response
Actual behavior
No response
How to Reproduce?
No response
Output of
uname -a
orver
No response
Output of
java -version
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: