Add OTel Metrics

quarkusio · Feb 27, 2024 · 3bbacbf · 3bbacbf
1 parent e916e5f
commit 3bbacbf
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/...ry/deployment/src/test/java/io/quarkus/opentelemetry/deployment/metrics/GaugeCdiTest.java b/...ry/deployment/src/test/java/io/quarkus/opentelemetry/deployment/metrics/GaugeCdiTest.java
@@ -33,7 +33,7 @@ public class GaugeCdiTest {
                             .addAsResource(new StringAsset(TestSpanExporterProvider.class.getCanonicalName()),
                                     "META-INF/services/io.opentelemetry.sdk.autoconfigure.spi.traces.ConfigurableSpanExporterProvider")
                             .addAsResource(new StringAsset(InMemoryMetricExporterProvider.class.getCanonicalName()),
-                                    "META-INF/services/io.opentelemetry.sdk.autoconfigure.spi.traces.ConfigurableMetricExporterProvider")
+                                    "META-INF/services/io.opentelemetry.sdk.autoconfigure.spi.metrics.ConfigurableMetricExporterProvider")
                             .add(new StringAsset(
                                     "quarkus.datasource.db-kind=h2\n" +
                                             "quarkus.datasource.jdbc.telemetry=true\n" +

diff --git a/...ava/io/quarkus/opentelemetry/runtime/AutoConfiguredOpenTelemetrySdkBuilderCustomizer.java b/...ava/io/quarkus/opentelemetry/runtime/AutoConfiguredOpenTelemetrySdkBuilderCustomizer.java
@@ -170,14 +170,14 @@ public void customize(AutoConfiguredOpenTelemetrySdkBuilder builder) {
             builder.addTracerProviderCustomizer(
                     new BiFunction<>() {
                         @Override
-                        public SdkTracerProviderBuilder apply(SdkTracerProviderBuilder builder,
+                        public SdkTracerProviderBuilder apply(SdkTracerProviderBuilder tracerProviderBuilder,
                                 ConfigProperties configProperties) {
                             if (oTelBuildConfig.traces().enabled().orElse(TRUE)) {
-                                idGenerator.stream().findFirst().ifPresent(builder::setIdGenerator); // from cdi
+                                idGenerator.stream().findFirst().ifPresent(tracerProviderBuilder::setIdGenerator); // from cdi
                                 spanProcessors.stream().filter(sp -> !(sp instanceof RemoveableLateBoundBatchSpanProcessor))
-                                        .forEach(builder::addSpanProcessor);
+                                        .forEach(tracerProviderBuilder::addSpanProcessor);
                             }
-                            return builder;
+                            return tracerProviderBuilder;
                         }
                     });
         }

diff --git a/...rc/main/java/io/quarkus/opentelemetry/runtime/metrics/spi/MetricsExporterCDIProvider.java b/...rc/main/java/io/quarkus/opentelemetry/runtime/metrics/spi/MetricsExporterCDIProvider.java
@@ -16,6 +16,6 @@ public MetricExporter createExporter(ConfigProperties configProperties) {
 
     @Override
     public String getName() {
-        return CDI_VALUE; // FIXME add META-INF/services/io.opentelemetry.sdk.autoconfigure.spi.traces.ConfigurableMetricExporterProvider
+        return CDI_VALUE; // FIXME add META-INF/services/io.opentelemetry.sdk.autoconfigure.spi.metrics.ConfigurableMetricExporterProvider
     }
 }