Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename userName variable to username in security-webauthn #1482

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

ynojima
Copy link
Member

@ynojima ynojima commented Dec 17, 2024

Follow-up for quarkusio/quarkus#45132

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has integration/native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)

Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@FroMage FroMage marked this pull request as ready for review December 17, 2024 15:22
@FroMage
Copy link
Member

FroMage commented Dec 17, 2024

This probably won't pass CI until quarkusio/quarkus#45132 is merged, but fine.

Copy link

quarkus-bot bot commented Dec 17, 2024

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit 8685dc0.

Failing Jobs

Status Name Step Failures Logs Raw logs
Build - JDK 17 Build with Maven Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Build - JDK 17 #

- Failing: microprofile-graphql-client-quickstart security-webauthn-quickstart security-webauthn-reactive-quickstart and 1 more

📦 microprofile-graphql-client-quickstart

org.acme.microprofile.graphql.client.GraphQLClientTest.testDynamicClient line 27 - More details - Source on GitHub

java.lang.NullPointerException: Cannot invoke "java.util.List.contains(Object)" because "filmTitles" is null
	at org.acme.microprofile.graphql.client.GraphQLClientTest.testDynamicClient(GraphQLClientTest.java:27)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:950)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:800)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	Suppressed: io.smallrye.graphql.client.InvalidResponseException: Unexpected response. Code=301, message="Moved Permanently", body="null"

org.acme.microprofile.graphql.client.GraphQLClientTest.testTypesafeClient line 19 - More details - Source on GitHub

java.lang.NullPointerException: Cannot invoke "java.util.List.contains(Object)" because "filmTitles" is null
	at org.acme.microprofile.graphql.client.GraphQLClientTest.testTypesafeClient(GraphQLClientTest.java:19)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:950)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:800)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	Suppressed: io.smallrye.graphql.client.InvalidResponseException: Unexpected response. Code=301, message="Moved Permanently", body="null"

📦 security-webauthn-quickstart

Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project security-webauthn-quickstart: Compilation failure

📦 security-webauthn-reactive-quickstart

Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project security-webauthn-reactive-quickstart: Compilation failure

📦 vertx-quickstart

org.acme.extra.ResourceUsingWebClientTest.testStarWarsData line 19 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.
Expected: a string containing "Luke Skywalker"
  Actual: {"code":404,"message":"<html>\r\n<head><title>404 Not Found</title></head>\r\n<body>\r\n<center><h1>404 Not Found</h1></center>\r\n<hr><center>nginx/1.16.1</center>\r\n</body>\r\n</html>\r\n"}

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)

@FroMage FroMage merged commit ea20946 into quarkusio:development Dec 17, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants