Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Quarkus CXF & Camel Quarkus 3.18.0 #1398

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

jamesnetherton
Copy link
Collaborator

@jamesnetherton
Copy link
Collaborator Author

@ppalaga I had to disable the Camel CXF SOAP tests and some QCXF tests due to this issue:

apache/camel-quarkus#6940

Not sure if it's just specific to the test suite or whether there's some wider problem. The CQ itests are passing with QCXF 3.18.0 so I am a bit confused about it.

@jamesnetherton jamesnetherton changed the title Quarkus CXF & Camel Quarkus 3.18.0 Upgrade to Quarkus CXF & Camel Quarkus 3.18.0 Jan 27, 2025

This comment has been minimized.

@ppalaga
Copy link
Collaborator

ppalaga commented Jan 27, 2025

Thanks for filing the issue, @jamesnetherton.

As far as I can see, it is caused by the fact that the generated Camel BOM does not contain the org.bouncycastle:* exclusion on org.apache.wss4j:wss4j-ws-security-common which we have in io.quarkiverse.cxf:quarkus-cxf-bom. Let me figure out why is that the case.

Copy link
Collaborator

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not merge like this.

@ppalaga
Copy link
Collaborator

ppalaga commented Jan 27, 2025

The problem comes from Camel Quarkus, where the generated change in Camel Quarkus poms/bom/src/main/generated/flattened-reduced-pom.xml

https://github.com/apache/camel-quarkus/blame/9cdddfff62b1de58c2c83b638707cd9a1d7202b2/poms/bom/src/main/generated/flattened-reduced-pom.xml#L7705-L7708

was commited in Next is 3.19.0-SNAPSHOT but not before the 3.18.0 release.

To avoid blocking Platfrom 3.18.0, let's add the exclusion in the generator config.

@ppalaga
Copy link
Collaborator

ppalaga commented Jan 27, 2025

@jamesnetherton this should fix it: jamesnetherton#1 Please feel free to squash into this PR

@jamesnetherton
Copy link
Collaborator Author

@jamesnetherton this should fix it: jamesnetherton#1 Please feel free to squash into this PR

Thanks, tests passed locally.

This comment has been minimized.

@jamesnetherton
Copy link
Collaborator Author

@ppalaga I think CxfWssClientTest.loggingClient is potentially flaky. If you agree, I'll disable it.

@jamesnetherton
Copy link
Collaborator Author

@ppalaga I think CxfWssClientTest.loggingClient is potentially flaky. If you agree, I'll disable it.

Took the liberty of disabling them and opened issues:

quarkiverse/quarkus-cxf#1694
quarkiverse/quarkus-cxf#1695

Copy link

quarkus-bot bot commented Jan 28, 2025

Status for workflow CI Build

This is the status report for running CI Build on commit ca91626.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit d83dc27 into quarkusio:main Jan 28, 2025
4 checks passed
@gsmet
Copy link
Member

gsmet commented Jan 28, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants