Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MultiplePersistenceUnitTest by removing workaround that adds a gap of 50 as pool optimizer now uses pooled-lo strategy #375

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Mar 21, 2023

Quarkus now defaults to pooled-lo pool optimizer that avoid unsigned ids, so our workaround does not force ids of newly created rows (that's one created by application logic, not init script) to start right after rows inserted by init script. This PR updates next expected id so that next id is inserted right after the rows inserted by init script.

@michalvavrik michalvavrik requested a review from rsvoboda March 21, 2023 10:09
@michalvavrik michalvavrik force-pushed the feature/fix-hibernate-test branch from cd6671e to 283d105 Compare March 21, 2023 10:15
@michalvavrik michalvavrik changed the title Fix MultiplePersistenceUnitTest as id pool by default has gaps of 50 Fix MultiplePersistenceUnitTest by removing workaround as pool optimizer now uses pooled-lo strategy Mar 21, 2023
@michalvavrik michalvavrik changed the title Fix MultiplePersistenceUnitTest by removing workaround as pool optimizer now uses pooled-lo strategy Fix MultiplePersistenceUnitTest by removing workaround that adds a gap of 50 as pool optimizer now uses pooled-lo strategy Mar 21, 2023
@rsvoboda rsvoboda merged commit b3913e6 into quarkus-qe:main Mar 21, 2023
@michalvavrik michalvavrik deleted the feature/fix-hibernate-test branch March 21, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants