Add github authentication #74
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @vsevel @sberyozkin @kdubb , any thoughts on this? |
vsevel
reviewed
Sep 15, 2022
| @@ -271,6 +271,16 @@ echo token=$token | |||
| kubectl get secret $secret_name -o json | jq -r '.data."ca.crt"' | base64 -D > /tmp/ca.crt | |||
| ---- | |||
|
|
|||
| == GitHub Authentication | |||
There was a problem hiding this comment.
you can add a bullet point in the list given at the beginning.
| @@ -34,6 +34,15 @@ | |||
| "code", | |||
| "maintenance" | |||
| ] | |||
| }, | |||
There was a problem hiding this comment.
do we need to add this as part of the PR @gastaldi ?
There was a problem hiding this comment.
No, please add it in a separate PR using the @all-contributors add @r00ta for code command (which can be triggered by a comment in this PR)
| @@ -271,6 +271,16 @@ echo token=$token | |||
| kubectl get secret $secret_name -o json | jq -r '.data."ca.crt"' | base64 -D > /tmp/ca.crt | |||
| ---- | |||
|
|
|||
| == GitHub Authentication | |||
|
|
|||
| The GitHub authentication rely on a token with the `admin:org->read:org` scope generated from https://github.com/settings/tokens/new. | |||
| public class VaultGitHubAuthenticationConfig { | ||
|
|
||
| /** | ||
| * Token for GitHub auth method. This property is required when selecting the github authentication type. |
There was a problem hiding this comment.
we don't choose, do we? it is implicit when we set this attribute. correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STILL WIP - Early feedback is more than welcome: i.e. if this feature is a nice to have for the project I'm happy to move on with the integration tests. I've already tested it locally and it works fine.
Relates to #73
This PR aims to provide GitHub as authentication mechanism for the vault.