Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add native test and support #18

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

dufoli
Copy link
Contributor

@dufoli dufoli commented Mar 28, 2021

fix #8

run: mvn -B formatter:validate verify --file pom.xml

- name: Build - Native
run: mvn -B verify -Pnative --file integration-tests/pom.xml
Copy link

@famod famod Mar 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you are physically limiting the Maven reactor to just this one module integration-tests, which is fine, but this will need the runtime and deployment modules of the extension in the local repo. Otherwise resolution of those modules/artifacts will fail (because they are not part of the reactor).

Therefore you will have to use install in the previous "Build - JVM" step.
To avoid having the resulting extension artifacts in the Maven cache (they should be built freshly for each run), you should add something like the following (after this step):

      - name: Delete Local Artifacts From Cache
        shell: bash
        run: rm -r ~/.m2/repository/io/quarkiverse/rsocket

/cc @gastaldi I haven't had a look at how other quarkiverse extensions work, so you might have another suggestion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@famod that makes sense, I don't think we're doing anything like that in the other extensions too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad , I have merges 2 files from different project....
I just focused on pom files because I was thinking it come from that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

native support
3 participants