Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): Release 3.0.3 #142

Merged
merged 1 commit into from
Jan 9, 2025
Merged

chore(release): Release 3.0.3 #142

merged 1 commit into from
Jan 9, 2025

Conversation

edeweerd1A
Copy link
Contributor

Have to deactivate Vale as the workflow is failing.

@edeweerd1A edeweerd1A requested a review from a team as a code owner January 9, 2025 12:51
@edeweerd1A edeweerd1A force-pushed the release-3.0.3 branch 5 times, most recently from 1fd92e0 to 2656bbb Compare January 9, 2025 13:40
@@ -404,7 +404,7 @@ Its responsibility is to retry indefinitely the `@io.quarkiverse.kafkastreamspro

==== Configuration

The default behavior can be overriden via the following configuration, ie:
The default behavior can be overridden via the following configuration, ie:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[RedHat.Spelling] Verify the word 'overriden'. It is not in the American English spelling dictionary used by Vale.

@@ -404,7 +404,7 @@

==== Configuration

The default behavior can be overriden via the following configuration, ie:
The default behavior can be overridden via the following configuration, ie:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[RedHat.TermsWarnings] Consider using 'that is' rather than 'ie' unless updating existing content that uses the term.

@@ -404,7 +404,7 @@

==== Configuration

The default behavior can be overriden via the following configuration, ie:
The default behavior can be overridden via the following configuration, ie:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[RedHat.Spelling] Verify the word 'ie'. It is not in the American English spelling dictionary used by Vale.

@@ -447,7 +447,7 @@
There's a possible impact on Prometheus because this could drastically increase the amount of data needed to store the time series.
To understand how IDs label are computed, one can read the following documentation on https://docs.confluent.io/platform/{kafka_confluent_version}/streams/monitoring.html#get-runtime-information-on-kafkastreams-clients[KafkaStreams runtime information]

To mitigate the impact, it is a good practice to fix arbitrary prefix to dynamic labels but still, the dynamicity cannot be removed entirely.
To mitigate the impact, it is a good practice to fix arbitrary prefix to dynamic labels but still, the variability cannot be removed entirely.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[RedHat.Spelling] Verify the word 'dynamicity'. It is not in the American English spelling dictionary used by Vale.

@@ -489,7 +489,7 @@

| kafkastreamsprocessor.punctuation.errors
| Counter
| The number of times a Punctuator's execution failed with an exception since the start of the microservice.
| The number of times the execution of a `Punctuator` failed with an exception since the start of the microservice.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[RedHat.Spelling] Verify the word 'Punctuator's'. It is not in the American English spelling dictionary used by Vale.

@@ -769,7 +769,7 @@
----
<3> The decorator should have the same generics declaration `<KIn, VIn, KOut, VOut>` as the `Processor<KIn, VIn, KOut, VOut>` interface that it implements
<4> Delegate reference to use when decorating methods.
It is annotated with lombok's https://projectlombok.org/features/experimental/Delegate[Delegate] annotation to generate passthrough decorated methods that this Decorator class won't decorate.
It is annotated with https://projectlombok.org/features/experimental/Delegate[Delegate] annotation from Lombok to generate passthrough decorated methods that this Decorator class won't decorate.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[RedHat.Spelling] Verify the word 'lombok's'. It is not in the American English spelling dictionary used by Vale.

@@ -912,8 +912,8 @@
<3> The decorator should extend the `DecoratedPunctuator` interface defined by this extension.
It won't be considered otherwise.
<4> Delegate reference to use when decorating methods.
It is annotated with lombok's https://projectlombok.org/features/experimental/Delegate[Delegate]
annotation to generate passthrough decorated methods that this Decorator class won't decorate.
It is annotated with https://projectlombok.org/features/experimental/Delegate[Delegate]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[RedHat.Spelling] Verify the word 'lombok's'. It is not in the American English spelling dictionary used by Vale.

@csemaan1A
Copy link
Contributor

in attributes.adoc, bump the project-version to 3.0.3

@edeweerd1A
Copy link
Contributor Author

in attributes.adoc, bump the project-version to 3.0.3

nope, that is does by the CI at releasing time

Fixed typos and non existing workds in index.yml.
docs/modules/ROOT/pages/index.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Show resolved Hide resolved
@csemaan1A
Copy link
Contributor

I don't know if you still can, but maybe remove "Have to deactivate Vale as the workflow is failing." from the first comment on the PR, i.e. PR description

@edeweerd1A edeweerd1A merged commit d65e5e2 into quarkus-3.8 Jan 9, 2025
3 checks passed
@edeweerd1A edeweerd1A deleted the release-3.0.3 branch January 9, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants