Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Quarkus 3.0.0 #87

Closed
turing85 opened this issue Oct 25, 2022 · 51 comments
Closed

Prepare for Quarkus 3.0.0 #87

turing85 opened this issue Oct 25, 2022 · 51 comments

Comments

@turing85
Copy link
Contributor

turing85 commented Oct 25, 2022

In the advent of the Quarkus 3.0.0 release, we should prepare this extension.

@turing85

This comment was marked as outdated.

@middagj
Copy link
Contributor

middagj commented Oct 26, 2022

Great, let's wait for the first alpha and create a branch.

@zhfeng
Copy link
Contributor

zhfeng commented Oct 28, 2022

@middagj I find that you bump the version to 2.0.0 in the lastest release. So what is our stragtegy for the coming Quarkus 3? keep the main branch to align to Quarkus 3 and make 2.x branch for keeping support Quarkus 2.x?

@middagj
Copy link
Contributor

middagj commented Oct 28, 2022

Yes, that would be my proposal. Perhaps we can back port some features to the 2.x branch as well, but we won't do any major features.

The bump to 2.0.0 was to signal the changes in config.

@turing85
Copy link
Contributor Author

turing85 commented Oct 31, 2022

@middagj I plan to make an alpha release so that extensions that are depending on us can test compatibility. Thought of releasing as 3.0.0.Alpha1. What do you think?

@middagj
Copy link
Contributor

middagj commented Oct 31, 2022

If you have the time it would be an excellent idea. Can you make the release on a separate branch and merge it once we get out of alpha?

@turing85
Copy link
Contributor Author

I have a hunch that we can make a merge on the current feature branch, changing the version and everything should run. Will try it in a moment.

@turing85
Copy link
Contributor Author

turing85 commented Oct 31, 2022

Yup, just worked. Release pipeline is running.

@turing85
Copy link
Contributor Author

... welp...

@turing85
Copy link
Contributor Author

This was a trip and a half. We have a Release 3.0.0.Alpha1 and 3.0.0.Alpha2 now (2 releases b/c something with the pipeline went wrong, that's also the reason why there is no tag for 3.0.0.Alpha1).

@turing85
Copy link
Contributor Author

turing85 commented Oct 31, 2022

quarkus-pooled-jms cannot compile due to a version incompatibility of jarkarta.jms-api (we use 2.0.3 coming transitively from artemis-jms-client, quarkus-pooled-jms as well as quarkus-jta use 3.0.0).

I think we need a release of artemis-[core|jms]-client based on jakarta.jms-api version 3.0.0. @middagj can you confirm this? As of now, I see no way we can somehow "bridge" between two jakarta versions.

See quarkiverse/quarkus-pooled-jms#39 (comment) for details.

@zhfeng
Copy link
Contributor

zhfeng commented Nov 1, 2022

@turing85 Also it looks like we need to change to use org.apache.activemq:artemis-jakarta-client?

@turing85
Copy link
Contributor Author

turing85 commented Nov 1, 2022

@zhfeng didn't know they had a separate client. This is probably the solution to the problem.

@middagj
Copy link
Contributor

middagj commented Nov 1, 2022

Is there any convention in Quarkus with respect to the import order of jakarta.*?

@turing85
Copy link
Contributor Author

turing85 commented Nov 1, 2022

Not that I know of.

turing85 added a commit that referenced this issue Nov 3, 2022
turing85 added a commit that referenced this issue Nov 9, 2022
@turing85 turing85 self-assigned this Nov 9, 2022
@turing85
Copy link
Contributor Author

turing85 commented Jan 4, 2023

As of now, we cannot merge the "meat" of #121 into this branch since camel has not yet upgraded to quarkus 3. I have merged the non-essential parts (i.e. the test restructuring and the pipeline upgrades), but the rest can only be merged after we have a camel release that works with quarkus 3.

@turing85 turing85 linked a pull request Jan 4, 2023 that will close this issue
@turing85 turing85 removed a link to a pull request Jan 4, 2023
@zhfeng
Copy link
Contributor

zhfeng commented Feb 10, 2023

@turing85 @middagj Quarkus 3 has been out last week. Then I wonder if we need to bump our main branch to support Quarkus 3 and create a new branch quarkus-2.x to maintain Quarkus 2.16.x. As far as I know, there is no plan to release 2.17 with Quarkus.

@turing85
Copy link
Contributor Author

@zhfeng 2.17 is in deed not planned. I see, however, no 3.0.0 release in mvnrepository, nor a 3.0.0 tag in github. Are you sure a final version is out?

@turing85

This comment was marked as outdated.

@gastaldi

This comment was marked as outdated.

gastaldi added a commit to quarkiverse/quarkiverse-devops that referenced this issue Feb 12, 2023
@zhfeng

This comment was marked as outdated.

@zhfeng

This comment was marked as outdated.

@middagj

This comment was marked as outdated.

@turing85

This comment was marked as outdated.

@zhfeng
Copy link
Contributor

zhfeng commented Feb 16, 2023

@turing85 Are you going to do a new Alpha release of 3.0.0 after switching?

@turing85
Copy link
Contributor Author

@zhfeng I did not plan to, no.

@turing85
Copy link
Contributor Author

Starting the process now.

@turing85
Copy link
Contributor Author

Switch is done.

@turing85

This comment was marked as outdated.

@middagj

This comment was marked as outdated.

@middagj
Copy link
Contributor

middagj commented Feb 16, 2023

Camel support was removed on purpose I recon. I didn't see anything strange, just Javadoc that got over 120 line width due to renaming.

@turing85
Copy link
Contributor Author

Camel support was removed on purpose I recon. I didn't see anything strange, just Javadoc that got over 120 line width due to renaming.

Yes, the camel-parts were removed on purpose. See #154 for details.

As for the line length... is this not covered by the autoformatter?

@middagj
Copy link
Contributor

middagj commented Feb 17, 2023

No, apparently not. But fixed it.

@turing85
Copy link
Contributor Author

turing85 commented Apr 13, 2023

Official release is on 2023-04-26 (groups.google.com). How about we build the 3.0.0 1 day before, i.e. on 2023-04-25?

@zhfeng
Copy link
Contributor

zhfeng commented Apr 13, 2023

@turing85 Can we release two days before because I also need to release quarkus-pooled-jms which depends on quarkus-artems-jms although it is just for testing.

@turing85
Copy link
Contributor Author

turing85 commented Apr 13, 2023

So 2023-04-24 it is 🙂

@turing85
Copy link
Contributor Author

Ad discussed with @zhfeng here, we decided to release on 2023-04-20.

@gsmet
Copy link
Member

gsmet commented Apr 20, 2023

It's today so cool for me :).

Please ping me in the release PR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants