Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make quarkus.artemis.url optional #36

Closed
zhfeng opened this issue Apr 12, 2022 · 1 comment · Fixed by #82
Closed

Make quarkus.artemis.url optional #36

zhfeng opened this issue Apr 12, 2022 · 1 comment · Fixed by #82
Labels
enhancement New feature or request

Comments

@zhfeng
Copy link
Contributor

zhfeng commented Apr 12, 2022

I just moved quarkusio/quarkus#18231 here to track it.
@zhfeng zhfeng mentioned this issue Apr 12, 2022
Closed
@turing85 turing85 mentioned this issue Oct 9, 2022
Merged
@turing85
Copy link
Contributor

@zhfeng What is the current status on how this should behave? Based on the implementation I am doing in #20, I can quite easily:

  • return nulls when the URL is not set at runtime
  • exclude everything with null URL from the health check(s).

This could ultimately lead to a situation where the health endpoint has no items, i.e. always returns "UP".

Are those specifications acceptable?

This was referenced Oct 15, 2022
Merged
Closed
middagj pushed a commit that referenced this issue Oct 21, 2022
@turing85 @middagj
#36: make configuration value url optional
0ff8034
@turing85 turing85 mentioned this issue Oct 29, 2022
Merged
@timonzi timonzi mentioned this issue Nov 2, 2022
Closed
@turing85 turing85 added the enhancement New feature or request label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#36: make configuration value url optional
2 participants
@zhfeng @turing85