Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types for react-hook-form 7.45 #1997

Merged
merged 2 commits into from
Jul 1, 2023
Merged

Fix types for react-hook-form 7.45 #1997

merged 2 commits into from
Jul 1, 2023

Conversation

berekuk
Copy link
Collaborator

@berekuk berekuk commented Jul 1, 2023

Caused by react-hook-form/react-hook-form#10342.

Thanks to FieldPathByValue, our form component types are now more strict, and check not just for the name being present in form, but also for its specific type (string, number, etc.).

@berekuk berekuk requested review from Hazelfire and OAGr as code owners July 1, 2023 20:48
@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2023

⚠️ No Changeset found

Latest commit: 84a092b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2023 10:10pm
quri-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2023 10:10pm
relative-values ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2023 10:10pm
squiggle-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2023 10:10pm
squiggle-website ✅ Ready (Inspect) Visit Preview Jul 1, 2023 10:10pm

@berekuk
Copy link
Collaborator Author

berekuk commented Jul 1, 2023

Also had to roll back react-textarea-autosize, because of Andarist/react-textarea-autosize#379.

@berekuk berekuk merged commit 07259a8 into develop Jul 1, 2023
@berekuk berekuk deleted the rhf-fixes branch July 1, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant