Skip to content
This repository has been archived by the owner on Apr 30, 2022. It is now read-only.

Use POST request for some datatables routes if request length is long #126

Merged
merged 21 commits into from
Nov 27, 2018
Merged

Use POST request for some datatables routes if request length is long #126

merged 21 commits into from
Nov 27, 2018

Conversation

jjmar
Copy link
Contributor

@jjmar jjmar commented Nov 20, 2018 •
edited
Loading

Overview

For the datatables show and bulk download routes, automatically make a POST request instead of a GET request when request URL exceeds 8000 characters.

Justin Martin added 18 commits November 16, 2018 11:32
Initial work on getting post requests working for datatable route
ab2b7ac
Initial work on getting post requests working for datatable export route
76c23eb
Additional work regarding post request body
16faa51
Begin work on formatting post request arguments correctly
08be06f
Format dictionary params correctly for post request
571279a
Update failing connection tests
ab6e8d2
Add .zip files to gitignore
8bf426b
Fix some failing tests due to httppretty
6d83c85
Add sanity tests for function determining request type
9b6487c
Add additional tests for modifying arguments to get/post request params
e9d26d0
Add venv to flake8 ignore list
0bd772d
Run existing connection tests for both get and post requests
eef854e
Fix some flake8 warnings
f4dacc2
Update some datatable tests to account for get and post requests
7129980
Update some datatable data tests for get/post requests
f55f5c2
Add config to always use post request for testing purposes
ba2768b
Add some more tests to ensure request made with correct params
f5e7f69
Fix incorrect params format being passed to mocked tests
95910a1
@jjmar jjmar self-assigned this Nov 20, 2018
@jjmar jjmar changed the title Cp 7349/implement python package to use new datapi post routes Use POST request for some datatables routes if request length is long Nov 20, 2018
@jjmar jjmar merged commit bf21b56 into master Nov 27, 2018
@jjmar jjmar deleted the CP-7349/implement-python-package-to-use-new-datapi-post-routes branch November 27, 2018 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fengshuo fengshuo fengshuo approved these changes

Assignees

@jjmar jjmar

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjmar @fengshuo