Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Parameter Tests #61

Merged
merged 109 commits into from
Jan 28, 2025
Merged

Add Parameter Tests #61

merged 109 commits into from
Jan 28, 2025

Conversation

OliverGlandberger
Copy link
Contributor

@OliverGlandberger OliverGlandberger commented Jan 20, 2025 •
edited
Loading

The main objective of this PR is to add tests to RTProtocol functionality that handles XML data. The following is a comprehensive list of noteworthy changes:

  • Added 'Build tests' option to CMakeLists.txt
  • Added dummy network class to better enable testing
  • Included Doctest testing library
  • Included tinyxml2, limited usage so far (within dummy network class)
  • Updated README.md with some building/testing instructions
  • Created additional 'Get' functions in RTProtocol to make testing easier
  • Added tests that aim to cover most, if not all, of RTProtocol functions that utilize the CMarkup library
  • Fixed skeleton XML-parsing bug in RTProtocol.cpp (line 4411)

image

qjgn and others added 29 commits January 16, 2025 14:38
@qjgn
Demo test
0a21099
@qjgn
First test passing
70b6521
@qjgn
Small cleanup
ca55dea
@qjgn
GetGeneralSettingsTest Pass
577c312
@qjgn
Updated formatting
5d516aa
@OliverGlandberger
Started implementing 'send' override for dummy network, started writi…
792a83c 
…ng 'SetGeneralSettingsTest' function, changed test code to run C++ 17 instead of 14.
@OliverGlandberger
'SetGeneralSettingsTest' function now works, but 'GetGeneralSettingsT…
a6b0b35 
…est' function has stopped working.
@qjgn
SetGeneralSettingsTest Passing
2053c49
@qjgn
Formatting change
319828b
@OliverGlandberger
Started adding 'SetExtTimeBaseSettingsTest'.
0d4d3a6
@OliverGlandberger
Added 'GetExtTimeBaseSettingsTest'.
dd4a4d5
@OliverGlandberger
Fixed test names.
7b7962b
@OliverGlandberger
Added 'SetCameraSettingsTest' function.
be465a3
@OliverGlandberger
Added 'GetCameraSettingsTest'.
d0fec6d
@OliverGlandberger
Added test data and the test for 'SetExtTimestampSettingsTest'.
e08563b
@qjgn
Updated project structure
199d0a0
@qjgn
Merge branch 'xml_tests' of https://github.com/qualisys/qualisys_cpp_sdk
ad2a8b0 
 into xml_tests
@qjgn
Merge branch 'xml_tests' of https://github.com/qualisys/qualisys_cpp_sdk
534fcc3 
 into xml_tests
@qjgn
Temporarily removed BUILD_TESTS option
dd3c6a9
@qjgn
Re-Added BUILD_TESTS to the root CMakeLists.txt
6c03fb8
@qjgn
removed Main.cpp from vcxproj
fe18281
@qjgn
Build tests OFF by default
7a23530
@qjgn
Added test instructions to README.md
0b1afc6
@qjgn
Added ---- TESTS --- section to CMakeLists.txt"
206a7ed
@OliverGlandberger
Update README.md
51a7f05
@OliverGlandberger
Update README.md
35e96f2
@OliverGlandberger
Update README.md
971eac6
@OliverGlandberger
Update README.md
1324093
@OliverGlandberger
Update README.md
1965aa5
@qjgn qjgn changed the title [DRAFT] Add XML tests [DRAFT] Add XML Tests Jan 20, 2025
@OliverGlandberger OliverGlandberger changed the title [DRAFT] Add XML Tests Add Parameter Tests Jan 24, 2025
@OliverGlandberger OliverGlandberger marked this pull request as ready for review January 24, 2025 12:19
qjgn
qjgn reviewed Jan 27, 2025
View reviewed changes
bahlborn
bahlborn reviewed Jan 27, 2025
View reviewed changes
bahlborn
bahlborn requested changes Jan 27, 2025
View reviewed changes
Copy link

@bahlborn bahlborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions made

OliverGlandberger and others added 11 commits January 28, 2025 09:38
@OliverGlandberger
Copy link
Contributor Author

@bahlborn Your suggestions have been resolved. Merging so that we can become unblocked.

@OliverGlandberger OliverGlandberger merged commit a19cab5 into master Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qjgn qjgn qjgn left review comments

@MrCeliaki MrCeliaki MrCeliaki approved these changes

@bahlborn bahlborn Awaiting requested review from bahlborn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OliverGlandberger @MrCeliaki @qjgn @bahlborn