Fix Clang Compiler Warnings (Errors) #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sent into lambda function now replaced with ampersand, and fixed issues in SkeletonParametersTests which gave warnings/errors when compiling with clang.
ulvs
approved these changes
Feb 18, 2025
qjgn
approved these changes
Feb 18, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
qjgn
reviewed
Feb 18, 2025
bahlborn
approved these changes
Feb 18, 2025
qjgn
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with Clang on Windows / Linux there were a few warnings that didn't appear in the other compilers we tested:
Tests Run