-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature replace cmarkup with tinyxml2 #109
Merged
OliverGlandberger
merged 88 commits into
master
from
feature_replace_cmarkup_with_tinyxml2
Feb 17, 2025
Merged
Feature replace cmarkup with tinyxml2 #109
OliverGlandberger
merged 88 commits into
master
from
feature_replace_cmarkup_with_tinyxml2
Feb 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed to tinyxml2 in 'SetSkeletonSettings', as well as dependant function. * Add else-statement to include 'LowerBound' and 'UpperBound' when 'Constraint' is missing. * Remove unnecessary explicit string-construction. * Removed pointers from functions, replaced with references.
* Changed 'Set6DOFBodySettings' to use tinyxml2. * Output is slightly different still. Saving progress. * Test now passes. Removed a newline at the start of the test data set for 6DOF. Not sure if it needs to be there or not. * Revert the data since the newline doesn't seem to matter. * Removed unnecessary explicit string-construction, renamed from 'doc' to 'oXML'.
* Updated 'SetForceSettings' function for Tinyxml2 serializer. * Change pointers to references where applicable in new code. * Change pointers to references where applicable in new code. * Fix merge issues.
* Saving progress. * Added 'SetForceSettings' function. * Remove unnecessary explicit string-construction. --------- Co-authored-by: johannes.gotlen <johannes.gotlen@qualisys.se>
* Added 'SetGeneralSettings' function. * Reverted 'AddXMLElementBool' functions to contain default-specified texts for 'True' and 'False' alternatives, since there are commented out functions that need to specify these texts. --------- Co-authored-by: johannes.gotlen <johannes.gotlen@qualisys.se>
…gs() (#74) * Implemented CTinyxml2Deserializer::DeserializeEyeTrackerSettings, CTinyxml2Deserializer::ReadXmlBool * formatted else * removed extra include * use static_cast --------- Co-authored-by: Oliver Glandberger <oliver.glandberger@qualisys.se>
…gs() (#76) * Implemented CTinyxml2Deserializer::DeserializeEyeTrackerSettings, CTinyxml2Deserializer::ReadXmlBool * formatted else * removed extra include * use static_cast * Tests passing
* Implemented CTinyxml2Deserializer::DeserializeEyeTrackerSettings, CTinyxml2Deserializer::ReadXmlBool * formatted else * removed extra include * use static_cast * Tests passing * Tests passing * Test passes
MrCeliaki
approved these changes
Feb 17, 2025
Capelliexp
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges feature branch which replaces
CMarkup
withtinyxml2
.This PR:
CMarkup
related filestinyxml2
as dependency for all of the projects (Used to only be required by the test project)In order to separate the specific library from the serialization boiler plate, this PR:
Serializer
andDeserializer
as thin wrappers aroundtinyxml2
SettingsSerializer
andSettingsDeserializer
filesIn order to fix issues that impeded testing during development, this PR:
gcc
andmingw
(string handling and unsupported pragma)True/true
double
andfloat
tinyxml2
dependency as a git submodule instead of using cmakesFetch content
featureCompleted feature branch PRs:
#70, #71, #72, #73, #74, #75, #76, #77, #78, #79, #80,
#81, #82, #83, #84, #85, #86, #87, #88, #89, #90, #91,
#92, #93, #94, #95, #96, #97, #100, #101, #102, #103,
#104, #105, #106, #107, #108