Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node parameters #56

Merged
merged 1 commit into from
Sep 26, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 34 additions & 1 deletion qualibrate/qualibration_node.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,13 @@
Generator,
Optional,
Sequence,
Type,
cast,
)

import matplotlib
from matplotlib.rcsetup import interactive_bk
from pydantic import ValidationError

from qualibrate.models.outcome import Outcome
from qualibrate.models.run_mode import RunModes
Expand Down Expand Up @@ -53,12 +55,16 @@ class QualibrationNode(
def __init__(
self,
name: str,
parameters: NodeCreateParametersType,
parameters: Optional[NodeCreateParametersType] = None,
description: Optional[str] = None,
*,
parameters_class: Optional[Type[NodeCreateParametersType]] = None,
modes: Optional[RunModes] = None,
):
logger.info(f"Creating node {name}")
parameters = self.__class__._validate_passed_parameters_options(
name, parameters, parameters_class
)
super(QualibrationNode, self).__init__(
name,
parameters,
Expand All @@ -81,6 +87,33 @@ def __init__(
if self._external_parameters is not None:
self._parameters = self._external_parameters

@classmethod
def _validate_passed_parameters_options(
cls,
name: str,
parameters: Optional[NodeCreateParametersType],
parameters_class: Optional[Type[NodeCreateParametersType]],
) -> NodeCreateParametersType:
if parameters is not None:
if parameters_class is not None:
logger.warning(
"Passed both parameters and parameters_class to the node "
f"'{name}'. Please use only parameters argument"
)
return parameters
if parameters_class is None:
return NodeCreateParametersType()
logger.warning(
"parameters_class argument is deprecated. Please use "
f"parameters argument for initializing node '{name}'."
)
try:
return parameters_class()
except ValidationError as e:
raise ValueError(
f"Can't instantiate parameters class of node '{name}'"
) from e

def __copy__(self) -> "QualibrationNode":
modes = self.modes.model_copy(update={"inspection": False})
instance = self.__class__(
Expand Down