Extend language code format #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
523fefb to
6bbe2a4
Compare
|
After comments in #668 limit extension to ISO 639-1 and 639-2: 2 or 3 alpha for now. |
herrvigg
added a commit
that referenced
this pull request
Sep 13, 2020
Fixes #836. Fixes partially #668. Major refactoring: language code format now handled with a unique regex. The new format allows 2 or 3-letter (ISO 639-2 and 639-3), lower case. Upper case values are only allowed for legacy codes but not for new entries. A migration of DB will be required before enforcing to lower case. URL checks remain case-insensitive (unchanged).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #668.
Language code format:
language[-script][-region]