-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSS for language col in WC products page #831
Conversation
@@ -0,0 +1,3 @@ | |||
.fixed .column-language { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does CSS column-language
come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it's the WooCommerce products page, apologies for the incorrect title
OK got it, it's about the products not the orders :) |
This fixed layout CSS in the |
I'm not a web designer but this doesn't look good. Imo an issue should be opened on WooCommerce to remove these % because they don't live well with the I think even that the fixed layout itself is a bad practice, it's only meant to make the computations faster maybe for mobile. But in 2020 i don't think i makes much sense. This comes from WP so it's certainly even harder to change. But it can be done independently i believe. The first thing is certainly to ask WC to switch to really-fixed size such as For qTranslate we should do something similar, avoid % and used a fixed size instead. |
I'm not having this issue. Have you checked resizing the table on a live install? Even with this change, the table is responsive and works for me. Below 783px, the table goes into 'compact' mode. The This is a fix to an already existing, big problem. My goal here is to just get things working so they are actually usable. Before: After: |
All right, i'm not super happy with the non-responsive layout but it is indeed depending on WC and they would have to improve it for the whole table. At least we are consistent with them and if they change it we can adapt later. |
There was a wrong path for the new CSS stylesheet. Fixed in #894. |
Fixes #804
I'm not sure if this is the best way - adding custom CSS files to each module - but it seems like the most extensible going forwards. I see that the acf module also does this.