Refactor admin CSS and LSB files #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CSS files for LSB should not be processed and embedded every time. This complicates the code and it's not efficient for the cache. Take the LSB CSS out of the embedded CSS and load them as CSS files. Rename the CSS files in lower case separated by hyphens. Rename the main `qtranslate_configuration.css` as `admin.css`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSS files for LSB should not be processed and embedded every time. This complicates the code and it's not efficient for the cache.
Load the LSB CSS as files as it's not dependent on embedded code (for user color).
Enable localization of LSB options.
Rename the CSS files in lower case separated by hyphens.
Rename the main
qtranslate_configuration.cssasadmin.css.Tidy up highlight CSS code.