Generalize ACF config and simplify options #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ACF options are difficult to grasp: - it should not be required to enter the name of the pages where the LSB are shown, these should be defined by the module. - the standard ACF input and text fields should always be supported. We should deprecate the ACF-QTX extended fields. Moreover the `shim` element used to set the LSB anchors is too fuzzy. It may appear several times with same id in the DOM. Also, it's unclear how the display hooks are handled, as they should not be dependent on the options. Refactor the ACF configuration to list clearly the supported pages, anchors and display fields. Remove the options for standard support (always true) and the list of pages for LSB (the config should be updated).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ACF options are difficult to grasp:
Moreover the
shimelement used to set the LSB anchors is too fuzzy. It may appear several times with same id in the DOM. Also, it's unclear how the display hooks are handled, as they should not be dependent on the options.Refactor the ACF configuration to list clearly the supported pages, anchors and display fields.
Remove the options for standard support (always true) and the list of pages for LSB (the config should be updated).