Add support of form attribute for detached input
#1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Input elements are usually created below a form to be submitted. There's another alternative with the `form` attribute that allows them to be placed anywhere in the document. This field was ignored by qTranslate, assuming all inputs below a form. This problem was first seen with ACF6 field group title (#1252). This patch considers this attribute before creating new elements. It is read in priority, before looking for the closest form.
27ca378 to
7f02634
Compare
herrvigg
added a commit
that referenced
this pull request
Nov 19, 2022
Though the `form` attribute is quite unusal, it becomes harder to find the hidden elements if those are created under the form. Better keep them together with the detached input field. The `qtranslate-edit-language` is an exception as it's unique for the whole form and not linked to other elements. Simplify the code by re-using `qtranxf_ce`. Extend it by sending the `beforeNode` instead of a boolean handling only the firstNode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input elements are usually created below a form to be submitted. There's another alternative with the
formattribute that allows them to be placed anywhere in the document.This field was ignored by qTranslate, assuming all inputs below a form. This problem was first seen with ACF6 field group title (#1252).
This patch considers this attribute before creating new elements. It is read in priority, before looking for the closest form.