Replace strftime with IntlDateFormatter for PHP8.1
#1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`strftime` is deprecated in PHP8.1 and should not be used anymore. Add a locale-formatted strftime using `IntlDateFormatter`. This patch is a temporary workaround for immediate PHP8.1 support. The `strftime` format should be abandonned completely in QTX so it becomes legacy from now. Mark all strftime methods as deprecated for PHPDoc but not for the PHP code yet, until a migration is done. Attention: QTX uses an extended version of strftime to support extra format tags such as `%q` that are non-standard in strftime.
|
Should solve #1085 as a temporary workaround. |
This was referenced Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strftimeis deprecated in PHP8.1 and should not be used anymore. Add a locale-formatted strftime usingIntlDateFormatter. This patch is a temporary workaround for immediate PHP8.1 support.The
strftimeformat should be abandonned completely in QTX so it becomes legacy from now. Mark all strftime methods as deprecated for PHPDoc but not for the PHP code yet, until a migration is done.Attention: QTX uses an extended version of strftime to support extra format tags such as
%qthat are non-standard in strftime.