QTS: replace slugs metabox only if existing #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herrvigg
reviewed
Aug 3, 2022
modules/slugs/admin/slugs-admin.php
Outdated
| remove_meta_box( 'slugdiv', null, 'normal' ); | ||
| add_meta_box( 'qts_sectionid', __( 'Slugs per language', 'qtranslate' ), 'qtranxf_slugs_draw_meta_box', null, 'side', 'high' ); | ||
| //Replace slugs metabox only if existing and not already removed | ||
| if ( ! empty($wp_meta_boxes[ get_current_screen()->id ][ 'normal' ][ 'core' ][ 'slugdiv' ] ) ) { |
There was a problem hiding this comment.
I can't test at this moment. Is this robust enough if one key is missing? I'm afraid empty will raise an exception if one key is missing - unlike unset.
There was a problem hiding this comment.
Based on php.net,
empty() is essentially the concise equivalent to !isset($var) || $var == false
which is what we need here, because that key may not be existing or may be false if already removed, so we should be covered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1207