-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show slug metabox on woo shop_orders and shop_coupon pages #1192
Conversation
The slug metaboxes might not be note necessary for the woocommerce orders and coupon pages...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@spleen1981 please could you review? As you have integrated WC with slugs you could have better feedbacks.
I had to rewrite without the null coalescing operator as this is PHP7.0 and QTX still allows PHP 5.4+. The requirements will be raised soon, but until then the retro-compatibility is needed.
Both @herrvigg as a side note these post types should not be translatable at all (ref. also #1116), we should check upstream and grey-up unchecked the relevant post types checkboxes in qtranslate advanced settings. |
The slug metaboxes might not be necessary for the woocommerce orders and coupon pages...