Refactor bool-array setting to QTX_BOOLEAN_SET
#1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `bool_elements_array` setting was introduced in #1135 and #1137. Re-using the QTX_ARRAY code with an extra argument makes it hard to maintain. The QTX_ARRAY type is not suited for set of checkboxes. Separate the logic by handling this type all separately. The `QTX_BOOLEAN_SET` was legacy, defined but not used in the code. Make the new type generic though only used by `ma_module_enabled`. Remove the extra `bool_elements_array` argument.
spleen1981
added a commit
to spleen1981/qtranslate-xt
that referenced
this pull request
Apr 18, 2022
* Refactor module activation handler and options Disambiguate the confusion between module state and admin options. The module state depends in general on other plugin states. The new admin options to manually disable or enable the modules are just preferences for the module activation. They should be stored regardless of the current state and can be deleted at any time. Rename the option to `modules_ma_enabled` and make it admin option. Refactor the module state update to separate the concepts. * Minor cleanup * Fix missing checkbox, cleanup module info * Refactor bool-array setting to `QTX_BOOLEAN_SET` (qtranslate#1151) The `bool_elements_array` setting was introduced in qtranslate#1135 and qtranslate#1137. Re-using the QTX_ARRAY code with an extra argument makes it hard to maintain. The QTX_ARRAY type is not suited for set of checkboxes. Separate the logic by handling this type all separately. The `QTX_BOOLEAN_SET` was legacy, defined but not used in the code. Make the new type generic though only used by `ma_module_enabled`. Remove the extra `bool_elements_array` argument. * Use `QTX_BOOLEAN_SET` for module checkboxes * Cleanup dead code * Fix module init on activation, complete doc * Rename `ma_enabled_modules` to `admin_enabled_modules` Co-authored-by: HerrVigg <herrvigg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bool_elements_arraysetting was introduced in #1135 and #1137.Re-using the QTX_ARRAY code with an extra argument makes it hard
to maintain. The QTX_ARRAY type is not suited for set of checkboxes.
Separate the logic by handling this type all separately.
The
QTX_BOOLEAN_SETwas legacy, defined but not used in the code.Make the new type generic though only used by
ma_module_enabled.Remove the extra
bool_elements_arrayargument.