Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WC: removed unneeded action mistakenly used as a filter #1145

Merged
merged 1 commit into from
Apr 1, 2022
Merged

WC: removed unneeded action mistakenly used as a filter #1145

merged 1 commit into from
Apr 1, 2022

Conversation

spleen1981
Copy link
Contributor

No description provided.

@spleen1981 spleen1981 merged commit 1107c11 into qtranslate:master Apr 1, 2022
@herrvigg herrvigg added the module: WC Integration with Woo Commerce label Apr 2, 2022
@herrvigg
Copy link
Collaborator

herrvigg commented Apr 2, 2022 •
edited
Loading

Sounds good if you found this useless, but we should simply remove it in that case or mention it differently.
I want to avoid keeping commented code.
Btw how was this patch merged? Do you have access to the admin override?

@spleen1981
Copy link
Contributor Author

Do you have access to the admin override?

Yes, ref. #1135 (comment) and #1141 (comment)

Sounds good if you found this useless, but we should simply remove it in that case or mention it differently.
I want to avoid keeping commented code.

Agree, only reason I left it there was that I was missing the original intent (to find an alternate solution), but I'm ok with removing the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module: WC Integration with Woo Commerce
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spleen1981 @herrvigg