QTS: revision and cleanup of add/edit terms slugs input code

[spleen1981]

No description provided.

[herrvigg]

I have some issues when saving a term, but I don't think it's coming just from this patch.

Warning: Undefined array key "es" in .../includes/class-qtranslate-slug.php on line 1346.

public function validate_term_slug( $slug, $term, $lang ) {
        global $q_config; //TODO: q_config  : term_name
        $term_key = qtranxf_split( $term->name );
        // after split we will get array (with language code as a key )
        $term_key = $term_key[ $this->default_language ];
        $name_in_lang = $q_config['term_name'][ $term_key ][ $lang ];

Here is category I'm testing

The $term_key becomes Actualités which is already quite weird, taking the name for the default language as a key.
The values are just set for FR, EN, DE in database, they are empty for IT and ES but here the form fields take the default language slug.

It's possible it doesn't handle well existing terms which are missing the slugs for every language.

[herrvigg]

Also, another consideration: why don't we use the Language Switch Buttons (LSB) instead of duplicating all the fields for every language? With the LSB enabled we should use those and keep a single "slug" field to stick the general UI offered by QTX.

[herrvigg]

Another minor bug, when we switch language with the LSB, the slug field (read-only) is not updated in the table.

It should change to news for english and so forth.

[herrvigg]

I don't expect all of this to be solved in this Pull Request, but I leave it for info.

Let me know what you think about these 3 last remarks and see how we proceed. We can first merge this patch if you like.

[herrvigg]

Point 1 (bug) - can be worth looked at in this PR.
Point 2 (LSB edit update) - require certainly much more changes with JS code. Can be treated as a feature request.
Point 3 (read-only update) - could be related to point 2, as the read-only updates are also done in JS.

[herrvigg]

Once this patch is merged, we should split this huge class-translate-slug.php file. It's way too big (1870 lines). The terms part could be taken out, among others.

[spleen1981]

Point 1 should be covered by 1d2653c, let me know if it works. I've removed unneeded complications which really did not seem to add value (besides the wrong implementation itself, with the missing check if key existed).
Point 2 & 3 need some reflection, as I think that slug metadata structure would need to be changed to use a single string same as translated content (e.g. [:en]slug1[:it]slug2[:]) rather than current mutiple strings, which is a big change in the module structure. Changing only javascript will only fix the LSB, but would not work in raw editor for example. However this makes sense and can be done, also for consistency with main plugin, but I would consider it as an enhancement and keep the matter on hold until the module is clean and stable. To formally fix the column bug for now, we may name the column "Slug (default language)".

[herrvigg]

Point 1 should be covered by 1d2653c, let me know if it works. I've removed unneeded complications which really did not seem to add value (besides the wrong implementation itself, with the missing check if key existed).

Yes it works, awesome!

[herrvigg]

Points 2 and 3: it will require more work, indeed. We can create separate tickets to keep track of it.