QTS: moved qts textdomain to qtranslate + general qtranslate pot/po/mo files re-alignment #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herrvigg
reviewed
Mar 12, 2022
| @@ -102,8 +102,8 @@ function qts_show_form_field( $args = array() ) { | |||
| case 'select': | |||
| echo "<select id='$id' class='select$field_class' name='" . QTS_OPTIONS_NAME . "[$id]'>"; | |||
| foreach ( $choices as $item ) { | |||
| $value = esc_attr( $item, 'qts' ); | |||
| $item = esc_html( $item, 'qts' ); | |||
There was a problem hiding this comment.
It seems the old calls were wrong with the domain being sent as 2d argument, but these functions only take 1 arg.
herrvigg
reviewed
Mar 12, 2022
| $sections['post_types'] = __( 'Post types', 'qts' ); | ||
| $sections['taxonomies'] = __( 'Taxonomies', 'qts' ); | ||
| $sections['post_types'] = __( 'Post types', 'qtranslate' ); | ||
| $sections['taxonomies'] = __( 'Taxonomies', 'qtranslate' ); |
There was a problem hiding this comment.
We could have re-used 'Taxonomy' from WP default domain, but no big deal.
|
Great! |
spleen1981
added a commit
to spleen1981/qtranslate-xt
that referenced
this pull request
Mar 13, 2022
…1120) * remove qts textdomain, merge with qtranslate, cleanup * update all po/mo files with new pot file, include existing qts translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.