Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please fix CSS styles for ACF #697

Closed
Tusko opened this issue May 30, 2019 · 4 comments
Closed

Please fix CSS styles for ACF #697

Tusko opened this issue May 30, 2019 · 4 comments

Comments

@Tusko
Copy link
Contributor

Tusko commented May 30, 2019

Hello!
Please fix styles in admin area for multilanguage inputs
http://cl.ly/d1692f

@herrvigg
Copy link
Collaborator

herrvigg commented May 31, 2019

@Tusko mmm... i don't know if you are aware but this is what i get from your website:

Attackers on d3a1eqpdtt5fg4.cloudfront.net may trick you into doing something dangerous like installing software or revealing your personal information (for example, passwords, phone numbers, or credit cards).

Google Safe Browsing recently detected phishing on d3a1eqpdtt5fg4.cloudfront.net. Phishing sites pretend to be other websites to trick you.

Not the most trustworthy thing to see. Anyway i could see the link. Btw why don't you just send a normal text instead of an image seen it's basic CSS? Weird. Also describing the change a bit can help. The CSS is only for ACF, .multi-language-field -> height: auto if i got it right.

@herrvigg
Copy link
Collaborator

herrvigg commented Jun 1, 2019

Also, height: auto is the default CSS. Why would need that? Can you show us what it is about? You can copy-paste images directly in github.

@Tusko
Copy link
Contributor Author

Tusko commented Jun 1, 2019

@herrvigg
image

Some fields have fixed height 28px (ACF Pro)
image

So, these styles will that bug
.multi-language-field -> height: auto

herrvigg added a commit that referenced this issue Jun 1, 2019
@herrvigg
Copy link
Collaborator

herrvigg commented Jun 1, 2019

OK i see. Thanks for the explanation, it's now fixed in the ACF module.

However i suggest you also send a small PR to the plugin this module is derived from: https://github.com/funkjedi/acf-qtranslate

It seems the author still maintains it. For now the module and the plugin live their own life so we need to sync them separately. This will make our life easier if we have to resync and other people still not using qTranslate-XT might also want this. We'll deal better with this question later.

@herrvigg herrvigg closed this as completed Jun 1, 2019
@herrvigg herrvigg changed the title Please fix styles Please fix CSS styles for ACF Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants