Bug in qtranxf_wp_head()

[herrvigg]

Issue by nb000
Wednesday Jul 15, 2015 at 14:33 GMT
Originally opened as qTranslate-Team/qtranslate-x#198

---

Hi there!
I am writing about version qTranslate-X 3.4.1.
In the function qtranxf_wp_head() where the meta tags are generated, you add the alternate language link tags. To this you call the qtranxf_convertURL(...) function.
As the last parameter is true, there could be URLs generated, which do not exists.

For example:
domain = example.com
active languages: hu, de, en
default language = hu
hide default language code from URL is set to true
On the URL http://example.com/de/somepageslug the following links are generated:

<link hreflang="hu" href="http://example.com/hu/somepageslug" rel="alternate" />
<link hreflang="de" href="http://example.com/de/somepageslug" rel="alternate" />
<link hreflang="en" href="http://example.com/en/somepageslug" rel="alternate" />
<link hreflang="x-default" href="http://example.com/sompageslug" rel="alternate" />

Here the first URL is invalid.
I think, the function should be called without the last parameter.

[herrvigg]

Comment by johnclause
Wednesday Jul 15, 2015 at 14:42 GMT

---

It is by design and is ok with google. This url must switch the language to hu even for google robots, which do not use cookies. This document may help: https://qtranslatexteam.wordpress.com/2015/02/26/browser-redirection-based-on-language/.

I am closing this issue for now, we can still write to closed issue and can re-open it if needed.

[herrvigg]

Comment by nb000
Thursday Jul 16, 2015 at 05:55 GMT

---

Answer is correct, and accepted.
Nice writing, but the linked page misses a piece of information:
the browser language based redirection can also be turned off at qTranslate-X settings.

[herrvigg]

@nb000 this was a very hold issue, but a fix is now released in qTranslate-XT 3.9.0 when the browser detection is disabled!