Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable translation for Standard Field Types #1279

Closed
rsfreire opened this issue Jan 25, 2023 · 5 comments
Closed

Disable translation for Standard Field Types #1279

rsfreire opened this issue Jan 25, 2023 · 5 comments
Labels
module: ACF Integration with ACF severity: major Major functionality

Comments

@rsfreire
Copy link

Hello there!

I believe the option to "Enable translation for Standard Field Types" was removed on the latest update, however I feel it's VERY useful to have some text fields non-translatable.

Is there any way to keep some fields non-translatable on the last version of the plugin, since the option to enable/disable this feature was removed?

Screen Shot 2023-01-25 at 07 34 40

Thanks!

@herrvigg
Copy link
Collaborator

I feel it's VERY useful to have some text fields non-translatable.

The problem is it didn't even allow to make some text fields non-translatable, it's all or nothing.
If you have ACF with qTranslate-XT which fields do you use the translations for? You can disable all translations in ACF by disabling the module.

@filtah
Copy link

filtah commented Feb 7, 2023

I feel it's VERY useful to have some text fields non-translatable.

The problem is it didn't even allow to make some text fields non-translatable, it's all or nothing. If you have ACF with qTranslate-XT which fields do you use the translations for? You can disable all translations in ACF by disabling the module.

You can translate 'some' fields easily, by selecting the qTranslate versions of those fields, and just use standard fields for those you don't want translated.

See: #1282

We depend on this feature (Enable translation for Standard Field Types), so cannot upgrade to 3.13.0.

@herrvigg
Copy link
Collaborator

herrvigg commented Feb 11, 2023

Now, as this checkbox has been removed, functionally it is set to ON, which changes the default behaviour and also renders the custom qTranslate-XT fields that get added at the bottom pretty useless.

In fact the idea for the long term is to remove the specific qTranslate-XT fields because they are harder to maintain.

It is really useful to have the option, because (in our case at least), there are often standard text fields which we don't want to translate for each language. For example, if we have a field for 'Villa Name', this would remain the same for each language, and we don't want to give the clients the option to change this text for each language.

The global option is not enough to select where the standard field should be translated, all or nothing for all posts is too restrictive. We'd need an additional option to extend the standard field. Using the "qTranslate-XT ACF" fields should only be seen a workaround.

Until then we can restore a global option. It could by refined by (standard) field type but there are only two supported: text, wysiwyg.

herrvigg added a commit that referenced this issue Mar 11, 2023
Restore and improve the ACF settings removed in 3.13.0.

Add new checkboxes for a finer tuning of the ACF std fields:
- content fields: text, textarea, wysiwyg
- group meta fields: label, description, default value.

For the default value, the type of content field associated with the
group field being edited must also be set e.g. text + default value.
@herrvigg
Copy link
Collaborator

ACF settings restored and improved. Added new checkboxes for a finer tuning of the ACF std fields:

  • content fields: text, textarea, wysiwyg
  • group meta fields: label, description, default value.

For the default value, the type of content field associated with the group field being edited must also be set e.g. text + default value.

image

herrvigg added a commit that referenced this issue Mar 12, 2023
herrvigg added a commit that referenced this issue Mar 25, 2023
Re-use standard type label from ACF registered types.
Make the default settings more flexible in case of changes.
Rename "content fields" as standard fields.
Rename "group meta fields" as group sub-fields" for consistency with ACF.
@herrvigg
Copy link
Collaborator

See also #1300. New panel for the extended fields.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: ACF Integration with ACF severity: major Major functionality
Projects
None yet
Development

No branches or pull requests

3 participants