Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MxSS RGB Handler Touchup #8105

Merged
merged 2 commits into from
Feb 18, 2020
Merged

MxSS RGB Handler Touchup #8105

merged 2 commits into from
Feb 18, 2020

Conversation

MxBlu
Copy link
Contributor

@MxBlu MxBlu commented Feb 6, 2020 •
edited
Loading

Slight tweak to some of the front LED keycode handlers to improve operation

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team February 6, 2020 09:49
@drashna drashna requested a review from a team February 8, 2020 02:59
@MxBlu
Copy link
Contributor Author

MxBlu commented Feb 18, 2020

Am I good to get a merge?

@fauxpark
Copy link
Member

Thanks!

@fauxpark fauxpark merged commit 0f500eb into qmk:master Feb 18, 2020
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@MxBlu @HokieGeek
MxSS RGB Handler Touchup (qmk#8105)
4b5045b 
* Minor fix to improve front LED brightness config

* Updated rgblight.c
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Feb 21, 2020
Merge remote-tracking branch 'upstream/master'
2a8ece2 
* upstream/master: (330 commits)
  Add Danish keymap and sendstring LUT (qmk#8218)
  format code according to conventions [skip ci]
  uart.c fix from TMK (qmk#7628)
  S75 Encoder Fixes (qmk#7758)
  Add Turkish keymap aliases and sendstring LUT (qmk#7676)
  Add Arm Teensys to mcu_selection.mk (qmk#8026)
  [New keyboard]silverbullet44 (qmk#7950)
  Allow 30us matrix delay to be keyboard/user overridable  (qmk#8216)
  Merge /prime_l and /prime_l_v2 (qmk#8194)
  [Keymap] Keymap for XD75 with 7U spacebar EN-RU gamers (qmk#8184)
  Add VIA support for kbd8x mk2 (qmk#8168)
  Move Grave/Tilde and some lesser used keys on my ergo boards (qmk#8200)
  [Keyboard] KC60SE cleanup (qmk#8171)
  Made windows driver installation accept y as All to allow CI (qmk#8189)
  Change the image photo of /keyboards/reviung41/readme.md (qmk#8195)
  MxSS RGB Handler Touchup (qmk#8105)
  Centromere Configurator layout support and readme update (qmk#8190)
  dynamic keymap sanity check (qmk#8181)
  [keyboard] Austin (qmk#8176)
  Use pathlib everywhere we can (qmk#7872)
  ...
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Feb 23, 2020
@MxBlu @sowbug
MxSS RGB Handler Touchup (qmk#8105)
5d39af1 
* Minor fix to improve front LED brightness config

* Updated rgblight.c
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Feb 27, 2020
Merge branch 'master' of https://github.com/nesth/qmk_firmware
70a02ed 
* 'master' of https://github.com/nesth/qmk_firmware: (331 commits)
  helix like crkbd
  Add Danish keymap and sendstring LUT (qmk#8218)
  format code according to conventions [skip ci]
  uart.c fix from TMK (qmk#7628)
  S75 Encoder Fixes (qmk#7758)
  Add Turkish keymap aliases and sendstring LUT (qmk#7676)
  Add Arm Teensys to mcu_selection.mk (qmk#8026)
  [New keyboard]silverbullet44 (qmk#7950)
  Allow 30us matrix delay to be keyboard/user overridable  (qmk#8216)
  Merge /prime_l and /prime_l_v2 (qmk#8194)
  [Keymap] Keymap for XD75 with 7U spacebar EN-RU gamers (qmk#8184)
  Add VIA support for kbd8x mk2 (qmk#8168)
  Move Grave/Tilde and some lesser used keys on my ergo boards (qmk#8200)
  [Keyboard] KC60SE cleanup (qmk#8171)
  Made windows driver installation accept y as All to allow CI (qmk#8189)
  Change the image photo of /keyboards/reviung41/readme.md (qmk#8195)
  MxSS RGB Handler Touchup (qmk#8105)
  Centromere Configurator layout support and readme update (qmk#8190)
  dynamic keymap sanity check (qmk#8181)
  [keyboard] Austin (qmk#8176)
  ...
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@MxBlu @c0psrul3
MxSS RGB Handler Touchup (qmk#8105)
a2ba270 
* Minor fix to improve front LED brightness config

* Updated rgblight.c
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@MxBlu @kujawakk
MxSS RGB Handler Touchup (qmk#8105)
4b0bb64 
* Minor fix to improve front LED brightness config

* Updated rgblight.c
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@MxBlu @jakeisnt
MxSS RGB Handler Touchup (qmk#8105)
636a0e0 
* Minor fix to improve front LED brightness config

* Updated rgblight.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MxBlu @fauxpark @drashna