Housekeeping on keymap_nathan.c, updated documentation
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The short name was incorrectly set as `KC_INT` when we want `KC_INS`.
Remove macro for KEYMAP_GRID that is in keymap_common.h. Add comments with ASCII art for the two layouts in keymap_common.h.
jackhumbert
added a commit
that referenced
this pull request
Mar 19, 2015
Housekeeping on `keymap_nathan.c`, updated documentation
jackhumbert
pushed a commit
that referenced
this pull request
Sep 8, 2016
User print disables the normal print messages in the body of QMK/TMK code and is meant as a lightweight alternative to NOPRINT. Use it when you only want to do a spot of debugging but lack flash resources for allowing all of the codebase to print (and store their wasteful strings).
mtei
referenced
this pull request
in mtei/qmk_firmware
Jun 3, 2018
Helix custom OLED font file for each keymap
alexey-danilov
pushed a commit
to alexey-danilov/qmk_firmware
that referenced
this pull request
Sep 21, 2018
# This is the 1st commit message: Easier switching between mac and win layers; logic for defining os-specific keys # This is the commit message qmk#2: sleep and power keys for win; added control-backspace instead of control-escape # This is the commit message qmk#3: adding wait in windows power/sleep macros # This is the commit message qmk#4: Adding switch to last window tap functinality; tweaked "mo_layer_tap" # This is the commit message qmk#5: An attempt to fix volume buttons in win # This is the commit message qmk#6: Fixed repeat function; changed win volume keys to f20-f22 # This is the commit message qmk#7: Added macros for vim save/quit # This is the commit message qmk#8: Fixes for single tap of palm keys on non-palm layers # This is the commit message qmk#9: Moved volume and home/end keys, changed double tap for left and right brackets, replaced = and - # This is the commit message qmk#10: Added minimize/maximize shortcuts for mac # This is the commit message qmk#11: Removed unnecessary maximize shortcut for mac # This is the commit message qmk#12: An attempt to fix volume buttons in win # This is the commit message qmk#13: added find next/previous (f3/shift-f3) keys # This is the commit message qmk#14: Remapped alt+tab/space; mo alt layer tap for win # This is the commit message qmk#15: Code refactoring; changing lang on mac via alt-space # This is the commit message qmk#16: Added dedicated keys for undo and f3; moved brackets # This is the commit message qmk#17: Moved exchanged GRV and Insert keys # This is the commit message qmk#18: Adjusted repeat timers # This is the commit message qmk#19: Added dedicated keys for curly braces # This is the commit message qmk#20: Added hold functionality to arrow keys in alt layer # This is the commit message qmk#21: Added macros for terminal # This is the commit message qmk#22: Added macro to clear terminal output in iterm2 (mac) and console (win) # This is the commit message qmk#23: Fixed save macro for vim, # This is the commit message qmk#24: Fixed clear command for conemu on win; changed location of volume keys # This is the commit message qmk#25: Replaced double tap k and comma macros with escape+key functionality # This is the commit message qmk#26: Re-added K-tap for lang change, added redo as a hold functionality for undo key, # This is the commit message qmk#27: Removed f3 and undo as a separate keys, removed k-tap combo; caps and change lang # This is the commit message qmk#28: Combination to close window; removed esc + 3 # This is the commit message qmk#29: Custom keycode for lang/caps, macro for closing app # This is the commit message qmk#30: Holding keys for esc layer,
ginjake
pushed a commit
to ginjake/qmk_firmware
that referenced
this pull request
Mar 3, 2019
サンシャインぴっかぴかモード2
manolodeinternet
added a commit
to manolodeinternet/qmk_firmware
that referenced
this pull request
Apr 11, 2019
BULLETPROOF ACCENTED E VOWEL !!! AT LAST, WHAT A RELIEF !!! It’s approached since low level coding, i.e.: modifying mods bits at QMK level of programming. This was inspired from QMK documentation, ‘void action_function(keyrecord_t *record, uint8_t id, uint8_t opt)’ and ‘#define GRAVE_MODS (MOD_BIT(KC_LSHIFT)|MOD_BIT(KC_RSHIFT)|MOD_BIT(KC_LGUI)|MOD_BIT(KC_RGUI)|MOD_BIT(KC_LALT)|MOD_BIT(KC_RALT))’ at ‘https://docs.qmk.fm/#/keymap?id=action_function’ The issue with accented acute vowels was that acute modifier for vowels didn’t appear while shift key was pressed. Instead of acute modifier for vowel, it appeared acute symbol followed by a space character. Thus we couldn’t accentuate the vowel, it appeared the acute symbol and the vowel after it. Then, instead of use `bool process_record_user(uint16_t keycode, keyrecord_t *record) }` we use now `void action_function(keyrecord_t *record, uint8_t id, uint8_t opt) {` and we modify mods bits directly, using `mod_shift_enable = get_mods()&LSHIFT_MODS;` `del_mods(mod_shift_enable);` `add_mods(mod_shift_enable);` In ˜/qmk_firmware/tmk_core/common/action_code.h we have codification for mods at bit level. /** \brief Key Actions * * Mod bits: 43210 * bit 0 ||||+- Control * bit 1 |||+-- Shift * bit 2 ||+--- Alt * bit 3 |+---- Gui * bit 4 +----- LR flag(Left:0, Right:1) */ enum mods_bit { MOD_LCTL = 0x01, MOD_LSFT = 0x02, MOD_LALT = 0x04, MOD_LGUI = 0x08, MOD_RCTL = 0x11, MOD_RSFT = 0x12, MOD_RALT = 0x14, MOD_RGUI = 0x18, }; And by this way, we can press acute accent and get an acute modifier, even while shift key is pressed !!! * modified file: keyboards/40percentclub/gdherkin/keymaps/30_layout/keymap.c, for correct acute accent behaviour while shift key is pressed. * renamed file: qmk_issues_log.txt into QMK_issues_log.txt, * modified file: QMK_issues_log.txt by adding the present acute accent issue committed in this commit
gebner
pushed a commit
to gebner/qmk_firmware
that referenced
this pull request
May 19, 2019
Add claw44_ble keyboard
ykeara
pushed a commit
to ykeara/qmk_firmware
that referenced
this pull request
Aug 24, 2019
) - In config.h of each, added '#define BOOTKEY_HOLD_MS 2000' to define hold time required to active Boot key (was 500ms hardcode) - Updated all active keymap.c files to use this define - Added line in quantum.c in MAGIC_TOGGLE_NKRO case to clear_keyboard() before toggling nkro state to fix stuck key issues when switching NKRO.
cjuniet
pushed a commit
to cjuniet/qmk_firmware
that referenced
this pull request
Sep 3, 2020
* Move custom keycodes from keymap files to the keyboard * Merge record thing from keymaps to already existing record thing in annepro2.c (already there for bluetooth key stuff) * Change handler for KC_AP_LED_ON so it changes the keymap before the user sees it * Add custom keycodes to switch led profiles * Improve readability in code
theol0403
pushed a commit
to theol0403/qmk_firmware
that referenced
this pull request
Oct 15, 2020
Co-authored-by: Manna Harbour <51143715+manna-harbour@users.noreply.github.com>
Shredder
pushed a commit
to Shredder/qmk_firmware
that referenced
this pull request
Jan 31, 2021
Co-authored-by: Manna Harbour <51143715+manna-harbour@users.noreply.github.com>
streof
pushed a commit
to streof/qmk_firmware
that referenced
this pull request
Mar 26, 2021
Co-authored-by: Manna Harbour <51143715+manna-harbour@users.noreply.github.com>
rizalfr
referenced
this pull request
in rizalfr/qmk_firmware
Jun 11, 2021
Reintroduced matrix tester, but it's disabled by default and requires…
daltona
pushed a commit
to daltona/qmk_firmware
that referenced
this pull request
Aug 28, 2021
Implement emulated EEPROM
lalalademaxiya2
pushed a commit
to lalalademaxiya2/qmk_firmware
that referenced
this pull request
Jan 27, 2022
revert some of pr qmk#6
thxph
pushed a commit
to thxph/qmk_firmware
that referenced
this pull request
Jul 25, 2022
shshsh11
pushed a commit
to shshsh11/qmk_firmware
that referenced
this pull request
Nov 13, 2022
Issue qmk#7: migrate all fingerpunch boards over to use new feature flag…
shshsh11
pushed a commit
to shshsh11/qmk_firmware
that referenced
this pull request
Nov 13, 2022
Issue qmk#8: add ffkb v3 support
mattpcaswell
pushed a commit
to mattpcaswell/qmk_firmware
that referenced
this pull request
Jun 7, 2023
* Add default keymaps for Planck revs. 1 and 2 * Add default keymap for Ergodox EZ
petrovs12
pushed a commit
to petrovs12/qmk_firmware_sval
that referenced
this pull request
May 21, 2024
EE hands and various pointing device builds
Lefuneste83
added a commit
to Lefuneste83/qmk_firmware_fork
that referenced
this pull request
Sep 10, 2024
y-usuzumi
pushed a commit
to y-usuzumi/qmk_firmware
that referenced
this pull request
Sep 19, 2024
…switch was mirrored (qmk#8)
spikespaz
pushed a commit
to spikespaz/qmk-firmware
that referenced
this pull request
Dec 28, 2024
…switch was mirrored (qmk#8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the macro definitions that are no longer needed as
KEYMAP_GRIDis now in the filekeymap_common.h. I also fixed an error in the documentation.I added comments showing a blank layout (with ASCII art, similar to those found in the other keyboard projects under tmk_keyboard) for each of the supported formats.