Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding personal rebound keymap #7956

Merged
merged 1 commit into from
Jan 22, 2020
Merged

adding personal rebound keymap #7956

merged 1 commit into from
Jan 22, 2020

Conversation

Rossman360
Copy link
Contributor

@Rossman360 Rossman360 commented Jan 21, 2020 •
edited by drashna
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

ridingqwerty
ridingqwerty approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rossman360
Copy link
Contributor Author

Oh, I think I see how that works!

noroadsleft
noroadsleft approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@drashna
Copy link
Member

drashna commented Jan 22, 2020

Thanks!

@drashna drashna merged commit bf4611c into qmk:master Jan 22, 2020
noroadsleft pushed a commit to noroadsleft/qmk_firmware that referenced this pull request Jan 24, 2020
@Rossman360 @noroadsleft
[Keymap] adding personal rebound keymap (qmk#7956)
53183e4
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@Rossman360 @HokieGeek
[Keymap] adding personal rebound keymap (qmk#7956)
0382706
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@Rossman360 @c0psrul3
[Keymap] adding personal rebound keymap (qmk#7956)
248a161
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@Rossman360 @kujawakk
[Keymap] adding personal rebound keymap (qmk#7956)
722a8ef
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@Rossman360 @drashna
[Keymap] adding personal rebound keymap (qmk#7956)
7d5e6cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ridingqwerty ridingqwerty ridingqwerty approved these changes

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rossman360 @drashna @ridingqwerty @noroadsleft