Partially port GET_SLAVE_STATUS from helix to split_common #7732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Dec 29, 2019
|
|
zvecr
added a commit
to zvecr/qmk_firmware
that referenced
this pull request
Jan 22, 2020
Partially port GET_SLAVE_STATUS from helix to split_common
zvecr
added a commit
that referenced
this pull request
Feb 4, 2020
Partially port GET_SLAVE_STATUS from helix to split_common
tzarc
approved these changes
Feb 21, 2020
tzarc
requested changes
Feb 21, 2020
|
|
||
| static uint8_t s_last_slave_buffer_change_count = 0; | ||
| if (soft_serial_transaction(GET_SLAVE_STATUS) == TRANSACTION_END && slave_buffer_change_count != s_last_slave_buffer_change_count) { | ||
| printf("matrix sync needed:%u:%u\n", slave_buffer_change_count, s_last_slave_buffer_change_count); |
There was a problem hiding this comment.
Lets remove the printf as it's causing CI failures.
There was a problem hiding this comment.
Also, dprintf would work better here, I think
16 tasks
|
I guess we could get this merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To help with the slower scan rates on the current arm_split branch, this PR partially ports some of the helix code to split_common. GET_SLAVE_STATUS aims to quickly query the slave side if anything has changed, before requesting the full slave side matrix. My limited testing gives about a +50% increase to scan rate.
Current scan rates
before
32u4 -> 1435
f303 -> 859
after
32u4 -> 2066
f303 -> 1321
In my limited testing with mashing keys, I have been unable to get f303 with GET_SLAVE_STATUS to slow down below what it was before. (Speedup might change for boards not ortho_4x12)
Types of Changes
Checklist