Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add docs build and deploy workflow #7448

Merged
merged 15 commits into from
Nov 10, 2020

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 22, 2019

Description

It sounds like we are kinda settled on a static generator for docs pages, but not which one to use.

So to set the process going, this PR gets the docs hooked up to a gh-pages branch, and pulls out the internal docs generation from the travis workflow. Short term, this helps us migrate CI, but longer term, we largely only have to slot in a different build command at a later date.

An example output is available at https://github.com/zvecr/qmk_firmware/tree/gh-pages

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the core label Nov 22, 2019
@zvecr zvecr requested a review from a team November 22, 2019 20:55
@stale
Copy link

stale bot commented Jan 14, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft requested a review from a team January 15, 2020 20:16
@zvecr zvecr force-pushed the feature/actions_docs branch from e827885 to 4ab09b7 Compare January 28, 2020 18:53
@zvecr zvecr changed the title Add docs build and deploy workflow CI: Add docs build and deploy workflow Feb 4, 2020
@zvecr zvecr added cli qmk cli command python labels Feb 12, 2020
@zvecr zvecr requested a review from Erovia February 12, 2020 15:51
@zvecr zvecr force-pushed the feature/actions_docs branch from 943c9f5 to 5b1f163 Compare February 12, 2020 15:53
@zvecr zvecr requested a review from a team February 12, 2020 15:59
@zvecr
Copy link
Member Author

zvecr commented Feb 12, 2020

CI changes might have to wait, or change in scope due to https://github.uint.cloudmunity/t5/GitHub-Actions/Github-action-not-triggering-gh-pages-upon-push/td-p/26869/highlight/true still being unresolved for public repos.

Or I need someone with additional permissions to create/configure a token.

Edit: The above is now resolved as described within the above link. Should be good to go now.

@zvecr zvecr force-pushed the feature/actions_docs branch from fd8a95a to f000163 Compare October 28, 2020 21:15
@github-actions github-actions bot added the CI label Oct 28, 2020
@zvecr zvecr force-pushed the feature/actions_docs branch from f000163 to f44971c Compare October 28, 2020 21:34
@github-actions github-actions bot added the core label Oct 29, 2020
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go for another green tick.

@skullydazed skullydazed merged commit aae3b35 into qmk:master Nov 10, 2020
ChrissiQ pushed a commit to ChrissiQ/qmk_firmware that referenced this pull request Nov 10, 2020
* Add docs build and deploy workflow

* Remove old travis docs workflow

* update to cli command

* Tidy up for review

* formatting

* Update to pass style checks

* Update lib/python/qmk/cli/docs.py

Co-Authored-By: skullydazed <skullydazed@users.noreply.github.com>

* Review comments - build->generate, use of verbose

* Add docs

* Update to match recent actions

* Run within base_container

* Convert cli to generate-docs

* Convert cli to generate-docs - restore old file

* Convert cli to generate-docs

* Update docs

Co-authored-by: skullydazed <skullydazed@users.noreply.github.com>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Add docs build and deploy workflow

* Remove old travis docs workflow

* update to cli command

* Tidy up for review

* formatting

* Update to pass style checks

* Update lib/python/qmk/cli/docs.py

Co-Authored-By: skullydazed <skullydazed@users.noreply.github.com>

* Review comments - build->generate, use of verbose

* Add docs

* Update to match recent actions

* Run within base_container

* Convert cli to generate-docs

* Convert cli to generate-docs - restore old file

* Convert cli to generate-docs

* Update docs

Co-authored-by: skullydazed <skullydazed@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants