Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use task driven PWM for CTPC until ARM can provide automatic configuration #6928

Merged
merged 2 commits into from
Nov 2, 2019
Merged

Use task driven PWM for CTPC until ARM can provide automatic configuration #6928

merged 2 commits into from
Nov 2, 2019

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 6, 2019 •
edited
Loading

Description

Requires #6709.

As an attempt at a "works everywhere" CTPC upgrade, in the short term ARM backlight can use the task driven software PWM.

Future Work

  • Add hardware PWM auto configuration

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the core label Oct 6, 2019
noroadsleft
noroadsleft approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

zvecr added a commit that referenced this pull request Oct 29, 2019
@zvecr
Merge pull request #6928 from zvecr/feature/backlight_CTPC
07b1109 
Use task driven PWM for CTPC until ARM can provide automatic configuration
@zvecr zvecr marked this pull request as ready for review November 2, 2019 21:20
@zvecr zvecr merged commit 1249da4 into qmk:master Nov 2, 2019
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Nov 17, 2019
@zvecr @drashna
Use task driven PWM for CTPC until ARM can provide automatic configur…
dee36da 
…ation (qmk#6928)

* Use task driven PWM for CTPC until ARM can provide automatic configuration

* Update CTPC docs to cover backlight
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@zvecr
Use task driven PWM for CTPC until ARM can provide automatic configur…
e055436 
…ation (qmk#6928)

* Use task driven PWM for CTPC until ARM can provide automatic configuration

* Update CTPC docs to cover backlight
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@zvecr @patrl
Use task driven PWM for CTPC until ARM can provide automatic configur…
821f88c 
…ation (qmk#6928)

* Use task driven PWM for CTPC until ARM can provide automatic configuration

* Update CTPC docs to cover backlight
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 2, 2020
@zvecr @drashna
Use task driven PWM for CTPC until ARM can provide automatic configur…
d445bd6 
…ation (qmk#6928)

* Use task driven PWM for CTPC until ARM can provide automatic configuration

* Update CTPC docs to cover backlight
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 6, 2020
@zvecr @fdidron
Use task driven PWM for CTPC until ARM can provide automatic configur…
78fe97c 
…ation (qmk#6928)

* Use task driven PWM for CTPC until ARM can provide automatic configuration

* Update CTPC docs to cover backlight
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 8, 2020
@zvecr @fdidron
Use task driven PWM for CTPC until ARM can provide automatic configur…
2b15486 
…ation (qmk#6928)

* Use task driven PWM for CTPC until ARM can provide automatic configuration

* Update CTPC docs to cover backlight
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@zvecr @HokieGeek
Use task driven PWM for CTPC until ARM can provide automatic configur…
9464d59 
…ation (qmk#6928)

* Use task driven PWM for CTPC until ARM can provide automatic configuration

* Update CTPC docs to cover backlight
@zvecr zvecr deleted the feature/backlight_CTPC branch April 28, 2020 00:43
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Use task driven PWM for CTPC until ARM can provide automatic configur…
f2a6f11 
…ation (qmk#6928)

* Use task driven PWM for CTPC until ARM can provide automatic configuration

* Update CTPC docs to cover backlight
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @noroadsleft