Add uzu42 keyboard #6842

nrtkbb · 2019-09-30T12:41:12Z

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna · 2019-09-30T18:04:51Z

Could this be converted over to Split Common, so that it's not using custom split keyboard code?
There are a couple of PRs open that go over how to do this.
For instance: #6260

Additionally, you may want to use OLED driver instead of the custom ssd1306 implementation, as it it much more feature rich (includes options like rotating the screen 90 degrees). As well as move most of the OLED code into the keymap, rather than having a "lib" full of files that do that?
https://docs.qmk.fm/#/feature_oled_driver

keyboards/uzu42/rev1/config.h

keyboards/uzu42/rev1/rev1.h

keyboards/uzu42/rules.mk

keyboards/uzu42/config.h

This reverts commit 5a9afce.

nrtkbb · 2019-10-01T16:30:42Z

Could this be converted over to Split Common, so that it's not using custom split keyboard code?
There are a couple of PRs open that go over how to do this.
For instance: #6260

Additionally, you may want to use OLED driver instead of the custom ssd1306 implementation, as it it much more feature rich (includes options like rotating the screen 90 degrees). As well as move most of the OLED code into the keymap, rather than having a "lib" full of files that do that?
https://docs.qmk.fm/#/feature_oled_driver

I tried to apply the reference modification, but the key input and the backlight LED became very unstable, so I reverted.
I just started learning about QMK, so I didn't know the cause. I'm sorry.

Co-Authored-By: fauxpark <fauxpark@gmail.com>

nrtkbb · 2019-10-02T23:21:43Z

@drashna
May I ask a question?
Is it possible to perform key input normally without connecting the OLED module with OLED_DRIVER_ENABLE = yes set?

keyboards/uzu42/rev1/rules.mk

drashna

Honestly, I'd really like to see the OLED code moved out of the lib folder, and thrown into the keymap.c folder.

This way, it's still present and available, but users can copy the kemap and customize it much more easily.

nrtkbb · 2019-10-06T09:43:37Z

@drashna
Thank you for your re-review and explaining!
I tried to fix it.

drashna

Looks good for the most part.

However, the only issue I have still, is the lib folder.

IMO, those files should be removed completely and the code in them moved to the keymap.c.

…eymap.c

… keymap.c

nrtkbb · 2019-10-14T15:11:41Z

@drashna
Thank you for your re-review again!
I tried to fix it.

drashna

Awesome, thanks!

* initial commit * OLEDに表示するロゴをuzuのものに差し替えた * delete undefault keymaps * delete info.json * delete pro_micro.h * remove USE_Link_Time_Optimization check * Moved constant defined for each keymap.c to rev1.h * update layer_state_reader.c * Rename Uzu42 to uzu42 * remove bootloader.h include * LAYOUT_kc to LAYOUT * delete keymap level rules.mk * update readme.md * remove persistent_default_layer_set function. * try refactor to use split_common and use OLED driver * Revert "try refactor to use split_common and use OLED driver" This reverts commit 5a9afce. * Update keyboards/uzu42/rev1/config.h Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/uzu42/rev1/rev1.h Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/uzu42/rev1/rev1.h Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/uzu42/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> * Remove lines already defined in QMK * Update keyboards/uzu42/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/uzu42/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/uzu42/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> * replaced comment block * Update keyboards/uzu42/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Revert "Revert "try refactor to use split_common and use OLED driver"" This reverts commit a784921. * fix setting for RGBLED * The default of OLED_DRIVER_ENABLE has been changed to no. * Delete unuse block. * Remove unnecessary keycode definitions. * Remove unuse custom keycode. * Remove not needed code. * Remove not called code. * Remove code overwritten by the core. * Remove LAYOUT_kc macro. * Moved the definition of the layer block to keymap.c. * Removed unuse variable. * Remove code overwritten by the core too. * incorporate layer changes * Moved src rule to keymap from rev1. * Removed rgb_state_reader.c from lib folder and the code move to the keymap.c * Removed layer_state_reader.c from lib folder and the code move to the keymap.c * Removed logo_reader.c from lib folder and the code move to the keymap.c * Removed keylogger.c from lib folder and the code move to the keymap.c * Moved glcdfont_uzu42.c from lib folder to the default keymaps folder. * Removed unused files.

nrtkbb added 16 commits April 18, 2019 10:54

initial commit

44e0406

OLEDに表示するロゴをuzuのものに差し替えた

68baa5d

delete undefault keymaps

e2ac9f9

Merge branch 'master' into uzu42

6241313

delete info.json

089217d

delete pro_micro.h

3bb6345

remove USE_Link_Time_Optimization check

7f93c39

Moved constant defined for each keymap.c to rev1.h

662df42

update layer_state_reader.c

ca9a4be

Rename Uzu42 to uzu42

9b9e21f

remove bootloader.h include

7b80e30

LAYOUT_kc to LAYOUT

9e8f105

delete keymap level rules.mk

fa2a980

update readme.md

d3e430f

remove persistent_default_layer_set function.

b6b18a9

Merge branch 'master' into uzu42

917edde

mechmerlin added the keyboard label Sep 30, 2019

drashna requested a review from a team September 30, 2019 18:04

fauxpark requested changes Sep 30, 2019

View reviewed changes

drashna reviewed Oct 1, 2019

View reviewed changes

keyboards/uzu42/config.h Outdated Show resolved Hide resolved

nrtkbb added 2 commits October 2, 2019 01:24

try refactor to use split_common and use OLED driver

5a9afce

Revert "try refactor to use split_common and use OLED driver"

a784921

This reverts commit 5a9afce.

nrtkbb and others added 6 commits October 2, 2019 01:31

Update keyboards/uzu42/rev1/config.h

cbd0dad

Co-Authored-By: fauxpark <fauxpark@gmail.com>

Update keyboards/uzu42/rev1/rev1.h

08cfeeb

Co-Authored-By: fauxpark <fauxpark@gmail.com>

Update keyboards/uzu42/rev1/rev1.h

55a94c5

Co-Authored-By: fauxpark <fauxpark@gmail.com>

Update keyboards/uzu42/rules.mk

719e775

Co-Authored-By: fauxpark <fauxpark@gmail.com>

Remove lines already defined in QMK

e28fc5e

Update keyboards/uzu42/rules.mk

6094006

Co-Authored-By: fauxpark <fauxpark@gmail.com>

nrtkbb added 8 commits October 3, 2019 06:39

Remove not needed code.

ad61e53

Remove not called code.

54ef543

Remove code overwritten by the core.

e1ff889

Remove LAYOUT_kc macro.

ab725e0

Moved the definition of the layer block to keymap.c.

ace3557

Removed unuse variable.

e5a85e0

Remove code overwritten by the core too.

afd1908

incorporate layer changes

62638b3

nrtkbb requested a review from drashna October 3, 2019 11:15

drashna reviewed Oct 5, 2019

View reviewed changes

keyboards/uzu42/rev1/rules.mk Outdated Show resolved Hide resolved

drashna reviewed Oct 5, 2019

View reviewed changes

Moved src rule to keymap from rev1.

409711d

nrtkbb requested a review from drashna October 6, 2019 09:42

drashna approved these changes Oct 8, 2019

View reviewed changes

nrtkbb added 6 commits October 14, 2019 23:22

Removed rgb_state_reader.c from lib folder and the code move to the k…

9b48e87

…eymap.c

Removed layer_state_reader.c from lib folder and the code move to the…

fec7e7d

… keymap.c

Removed logo_reader.c from lib folder and the code move to the keymap.c

d1ac13c

Removed keylogger.c from lib folder and the code move to the keymap.c

4a2d1b3

Moved glcdfont_uzu42.c from lib folder to the default keymaps folder.

a0b75fa

Removed unused files.

2295d6e

nrtkbb requested a review from drashna October 15, 2019 10:45

drashna approved these changes Oct 16, 2019

View reviewed changes

drashna merged commit 9b07098 into qmk:master Oct 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add uzu42 keyboard #6842

Add uzu42 keyboard #6842

nrtkbb commented Sep 30, 2019

drashna commented Sep 30, 2019

nrtkbb commented Oct 1, 2019

nrtkbb commented Oct 2, 2019

drashna left a comment

nrtkbb commented Oct 6, 2019

drashna left a comment

nrtkbb commented Oct 14, 2019

drashna left a comment

Add uzu42 keyboard #6842

Add uzu42 keyboard #6842

Conversation

nrtkbb commented Sep 30, 2019

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

drashna commented Sep 30, 2019

nrtkbb commented Oct 1, 2019

nrtkbb commented Oct 2, 2019

drashna left a comment

Choose a reason for hiding this comment

nrtkbb commented Oct 6, 2019

drashna left a comment

Choose a reason for hiding this comment

nrtkbb commented Oct 14, 2019

drashna left a comment

Choose a reason for hiding this comment