-
-
Notifications
You must be signed in to change notification settings - Fork 40.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noxary 268.2 update #6254
Merged
Merged
Noxary 268.2 update #6254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested review from
mechmerlin,
drashna,
noroadsleft,
yanfali and
zvecr
July 5, 2019 03:01
noroadsleft
approved these changes
Jul 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 👍
mechmerlin
approved these changes
Jul 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
doughsay
pushed a commit
to doughsay/qmk_firmware
that referenced
this pull request
Aug 31, 2019
* Fix Noxary 268.2 layout macros & info.json * Update Noxary 268.2 to current QMK code style
ripxorip
pushed a commit
to ripxorip/qmk_firmware
that referenced
this pull request
Dec 3, 2019
* Fix Noxary 268.2 layout macros & info.json * Update Noxary 268.2 to current QMK code style
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
* Fix Noxary 268.2 layout macros & info.json * Update Noxary 268.2 to current QMK code style
JeffreyPalmer
pushed a commit
to JeffreyPalmer/qmk_firmware
that referenced
this pull request
Feb 27, 2020
* Fix Noxary 268.2 layout macros & info.json * Update Noxary 268.2 to current QMK code style
swamp09
pushed a commit
to swamp09/qmk_firmware
that referenced
this pull request
Mar 11, 2020
* Fix Noxary 268.2 layout macros & info.json * Update Noxary 268.2 to current QMK code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing the Noxary 268.2 as it only has one LAYOUT macro, and the info.json didn't match.
Layout support is from here: https://typehype.net/threads/noxary-268-2.215/
As I don't actually own this keyboard, if someone who does can double/sanity check the matrix it would be appreciated. 👍
Types of Changes
Issues Fixed or Closed by This PR
Checklist