Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noxary 268.2 update #6254

Merged
merged 2 commits into from
Jul 7, 2019
Merged

Noxary 268.2 update #6254

merged 2 commits into from
Jul 7, 2019

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jul 5, 2019

Description

Fixing the Noxary 268.2 as it only has one LAYOUT macro, and the info.json didn't match.

Layout support is from here: https://typehype.net/threads/noxary-268-2.215/
As I don't actually own this keyboard, if someone who does can double/sanity check the matrix it would be appreciated. 👍

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mechmerlin mechmerlin merged commit dd1790c into qmk:master Jul 7, 2019
@fauxpark fauxpark deleted the noxary-268_2-update branch July 7, 2019 09:03
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
* Fix Noxary 268.2 layout macros & info.json

* Update Noxary 268.2 to current QMK code style
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
* Fix Noxary 268.2 layout macros & info.json

* Update Noxary 268.2 to current QMK code style
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
* Fix Noxary 268.2 layout macros & info.json

* Update Noxary 268.2 to current QMK code style
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
* Fix Noxary 268.2 layout macros & info.json

* Update Noxary 268.2 to current QMK code style
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
* Fix Noxary 268.2 layout macros & info.json

* Update Noxary 268.2 to current QMK code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split Backspace support for Noxary 268.2
4 participants