Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Keymap: 40percentclub Gherkin "useful" keymap and RGB configuration #6252

Merged
merged 1 commit into from
Jul 6, 2019

Conversation

michelgotta
Copy link
Contributor

Adding a new Keymap for the 3x10 Gherkin keyboard

Description

Keymap is configured for basic usage of writing and enabling basic bottom row keys (alt, gui) for usage of standard shortcuts (New Tab, Copy + Paste) and arrow keys.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@michelgotta
Copy link
Contributor Author

@drashna Was only a "Draft PR" but if you think it's fine, feel free to merge it! 💃

@michelgotta michelgotta marked this pull request as ready for review July 5, 2019 12:16
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@drashna drashna merged commit 853f523 into qmk:master Jul 6, 2019
@drashna
Copy link
Member

drashna commented Jul 6, 2019

Thanks!

kmac pushed a commit to kmac/qmk_firmware that referenced this pull request Jul 6, 2019
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants