Added keymap folder matching username to rorschach; added readme to old keympa #5970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
requested changes
May 24, 2019
|
|
||
| //Tap Dance Declarations | ||
| enum { | ||
| ADJ = 0, |
There was a problem hiding this comment.
Suggested change
| ADJ = 0, | |
| ADJ, |
This is not really necessary, the enum numbering always starts at 0.
|
|
||
| } | ||
| return false; | ||
| break; |
There was a problem hiding this comment.
break after return is dead code.
There was a problem hiding this comment.
Honestly, I think that removing return false is better than removing break.
Some functionality breaks if you return false (such as one shots).
| # the appropriate keymap folder that will get included automatically | ||
| # | ||
|
|
||
| BOOTMAGIC_ENABLE = no # Virtual DIP switch configuration(+1000) |
There was a problem hiding this comment.
You can remove all of these that haven't changed from the keyboard-level rules.mk.
drashna
approved these changes
Jul 30, 2019
raymond-w-ko
pushed a commit
to raymond-w-ko/qmk_firmware
that referenced
this pull request
Aug 4, 2019
…adme to old keympa (qmk#5970) * Added keymap folder matching username; added readme to old keymap * Update config.h
doughsay
pushed a commit
to doughsay/qmk_firmware
that referenced
this pull request
Aug 31, 2019
…adme to old keympa (qmk#5970) * Added keymap folder matching username; added readme to old keymap * Update config.h
swanmatch
pushed a commit
to swanmatch/qmk_firmware
that referenced
this pull request
Sep 3, 2019
…adme to old keympa (qmk#5970) * Added keymap folder matching username; added readme to old keymap * Update config.h
ripxorip
pushed a commit
to ripxorip/qmk_firmware
that referenced
this pull request
Dec 3, 2019
…adme to old keympa (qmk#5970) * Added keymap folder matching username; added readme to old keymap * Update config.h
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
…adme to old keympa (qmk#5970) * Added keymap folder matching username; added readme to old keymap * Update config.h
swamp09
pushed a commit
to swamp09/qmk_firmware
that referenced
this pull request
Mar 11, 2020
…adme to old keympa (qmk#5970) * Added keymap folder matching username; added readme to old keymap * Update config.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes