Updated hand wiring docs #5198
Merged
Updated hand wiring docs #5198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has bothered me for a while. Thanks @johannes-jansson. I'll probably make a run through the docs, because I know there are other instances of this issue in there. It's been driving me nuts for months. |
|
Thanks! |
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Mar 2, 2019
* renamed KEYMAP to LAYOUT in hand wiring docs * added two additional guides for hand wiring
slugger7
pushed a commit
to slugger7/qmk_firmware
that referenced
this pull request
Mar 7, 2019
* renamed KEYMAP to LAYOUT in hand wiring docs * added two additional guides for hand wiring
slugger7
pushed a commit
to slugger7/qmk_firmware
that referenced
this pull request
Apr 3, 2019
* renamed KEYMAP to LAYOUT in hand wiring docs * added two additional guides for hand wiring
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
* renamed KEYMAP to LAYOUT in hand wiring docs * added two additional guides for hand wiring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main reason for this PR was to replace the outdated KEYMAP function with the newer LAYOUT function. The setup script referred to in the docs is already updated, so the name confused me.
While I was at it, I added links to the two best visual step by step guides on hand wiring. Let me know if that's discouraged and I will make changes accordingly. I have no affiliations with the users who wrote the guides.
Types of Changes
Issues Fixed or Closed by This PR
Checklist