add Pinky(https://github.com/tamanishi/Pinky3) keyboard #4748
Conversation
|
If you have two different revisions of the PCB (3 and 4 pinky), you should really use these as the "revision", instead of using a configuration in the keymap (and rules.mk). Put most everything in the main folder, but change the pin defines in the subfolders, and then have a seperate keymap folder in each of these revisions. It would be a lot cleaner here. |
|
Thank you for reviewing. |
|
Happy New Year! |
There was a problem hiding this comment.
It appears that theys keyboard is using the normal split code (well, mtei's modified code), and doesn't use an SSD1306 OLED screen, at all.
If this is the case, then you should actually use the Split Common code instead.
In this case, you would need to remove the i2c, serial, matrix and split_util files from the keyboard folders, and you'd want to set SPLIT_KEYBOARD to yes.
The rest of the settings would remain the same, as mtei has merged most of this code into the core split common code.
The reason I am asking to do this, is that it would keep your board up to date with any of the newer changes, so that they don't have to be maintained separately.
- regenerate some files from the templates
|
Thank you for reviewing. |
| @@ -0,0 +1,46 @@ | |||
| #pragma once | |||
|
|
|||
| #include "../pinky.h" | |||
There was a problem hiding this comment.
You don't actually need the ".." here.
When compiling, both the subfolder and main folder (eg, pinky, and 3 in this case) are added to the "common path". So, you can call "pinky.h" directly, without having to use it's relative path.
It's fin to do this, but "for the future"... it's something to keep in mind.
There was a problem hiding this comment.
I understood. I'll keep that in mind.
|
Awesome, thanks! |
* 'master' of https://github.com/qmk/qmk_firmware: (63 commits) Keymap: ave-63's iris layout (qmk#4812) Update bakingpy 4x12 keymap and add test mode for debugging/development (qmk#4810) Fix Mac mute keycode (qmk#4809) Add KBD75 keymap (qmk#4808) Fix pinout of split hand and LED, remove flip half option Tidy up Mod-Tap shortcuts (qmk#4806) Add missing parentheses to some important macros (qmk#4775) Keyboard: Downbubble refactor and Configurator fix (qmk#4798) Alternate keymap for Alpha keyboard, enjoy! (qmk#4797) Keymap: Added Model F-inspired layout for YMD[K]96 (qmk#4777) Improve consistency in UNICODEMAP code and docs, update docs/understanding_qmk (qmk#4774) Update to arm_atsam wait and timer routines Add Downbubble to Handwired repository (qmk#4794) Final HS60v2 changes. (qmk#4790) Keyboard: Fractal layout macro and readme cleanup (qmk#4789) Keymap: added my espectro keymap (qmk#4791) Keyboard: Numbrero: Configurator fix and code tidy (qmk#4787) Keyboard: Tradestation code tidy and readme refactor (qmk#4784) Keyboard: update readme with ps2avr flashing instructions (qmk#4776) add Pinky keyboard (qmk#4748) ...
add Pinky (https://github.com/tamanishi/Pinky3) keyboard
add Pinky (https://github.com/tamanishi/Pinky3) keyboard
add Pinky (https://github.com/tamanishi/Pinky3) keyboard
This PR adds my new "Pinky" keyboard firmware.
Description
Add my new "Pinky" keyboard firmware.
Types of changes
Issues Fixed or Closed by this PR
Checklist: