Adding Split Space support for Mechmini 1 #4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noroadsleft
requested changes
Oct 3, 2018
| along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| #include "mechmini.h" |
There was a problem hiding this comment.
Please replace Lines 14-15 with #include QMK_KEYBOARD_H.
| #define _MOUSE 3 | ||
| #define _FUNCT 4 | ||
|
|
||
| #define _____ KC_TRNS |
There was a problem hiding this comment.
QMK defines a built-in keycode for this automatically.
qmk_firmware/quantum/quantum_keycodes.h
Lines 29 to 31 in 76f0b3c
It's much preferred to use the built-in keycode, rather than defining a different one here. Simply delete Line 23 and change all instances of _____ to _______.
| #define _____ KC_TRNS | ||
|
|
||
| const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | ||
| [_QWERTY] = SPLITSPACE_KEYMAP( |
There was a problem hiding this comment.
Please change all instances of SPLITSPACE_KEYMAP to LAYOUT_split_space. (Lines 26, 32, 38, 44, and 50.)
The desired terminology changed a while back and this usage is outdated.
keyboards/mechmini/v1/v1.h
Outdated
| @@ -40,4 +40,21 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| { KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO } \ | |||
| } | |||
|
|
|||
| #define SPLITSPACE_KEYMAP( \ | |||
There was a problem hiding this comment.
Please change SPLITSPACE_KEYMAP to LAYOUT_split_space.
|
@noroadsleft, this look good? |
noroadsleft
approved these changes
Oct 3, 2018
|
LGTM. I need to hit this with an |
|
Thanks! |
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Oct 5, 2018
* 'master' of https://github.com/qmk/qmk_firmware: (69 commits) rgb_matrix: continue calling rgb_matrix_indicators() when toggled off Keymap: Added personal userspace and keymaps. (qmk#4073) Add mousekey_send to (un)register_code rn42 compilation error fix (qmk#4050) process_ucis: Add a callback for success (qmk#4067) Keyboard: add info.json for qmk configurator (qmk#4063) Keyboard: Adding Split Space support for Mechmini 1 (qmk#4052) Keyboard: Added dactyl-manuform 4x6 and keymap. (qmk#4058) Keyboard: Add handwired/pteron config and keymaps (qmk#4060) Keyboard: Added split backspace layout for the b.mini (qmk#4051) Keyboard: Add namecard keyboard (qmk#4044) handwired/ibm122m: refactor and Configurator support (qmk#4054) Keyboard: Added JN68M keyboard to handwired (qmk#4053) Keymap: Add RGB matrix keypress effects and reduce firmware size. (qmk#4055) Keyboard: KBD4x: corrected info.json file (qmk#4056) Keyboard: Mint60: Configurator support and readme cleanup (qmk#4057) Add missing F-keys to ergodox_infinity input_club Enable support for Linux Mint 18 with linux_install.sh (qmk#4042) add JP keycode for MacOSX (qmk#4033) New keyboard: Baguette (qmk#4047) ...
akatrevorjay
added a commit
to akatrevorjay/qmk_firmware
that referenced
this pull request
Oct 8, 2018
* 'master' of git://github.com/qmk/qmk_firmware: (302 commits) Keymap: Added Planck keymap: jcorrado (qmk#4083) Keyboard: Helix five_rows keymap reduced size (qmk#4082) E6V2 LE HHKB love (qmk#4079) Keymap: Add french iso layout for dz60 (thomasviaud) (qmk#4080) ARM SWD guide Keyboard: set SAFE_RANGE (qmk#4078) Keyboard: DZ60: add Plate B layouts (qmk#4076) rgb_matrix: continue calling rgb_matrix_indicators() when toggled off Keymap: Added personal userspace and keymaps. (qmk#4073) Add mousekey_send to (un)register_code rn42 compilation error fix (qmk#4050) process_ucis: Add a callback for success (qmk#4067) Keyboard: add info.json for qmk configurator (qmk#4063) Keyboard: Adding Split Space support for Mechmini 1 (qmk#4052) Keyboard: Added dactyl-manuform 4x6 and keymap. (qmk#4058) Keyboard: Add handwired/pteron config and keymaps (qmk#4060) Keyboard: Added split backspace layout for the b.mini (qmk#4051) Keyboard: Add namecard keyboard (qmk#4044) handwired/ibm122m: refactor and Configurator support (qmk#4054) Keyboard: Added JN68M keyboard to handwired (qmk#4053) ...
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Oct 13, 2018
* Adding Split Space support * Adding my keymap * update * Made the requested updates * Made the requested update
rseymour
pushed a commit
to rseymour/qmk_firmware
that referenced
this pull request
Mar 13, 2019
* Adding Split Space support * Adding my keymap * update * Made the requested updates * Made the requested update
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
* Adding Split Space support * Adding my keymap * update * Made the requested updates * Made the requested update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adding my own keymap using the Split Space layout.