Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix Underglow keycode processing #24798

Merged
merged 2 commits into from
Jan 8, 2025
Merged

[Bug] Fix Underglow keycode processing #24798

merged 2 commits into from
Jan 8, 2025

Conversation

drashna
Copy link
Member

@drashna drashna commented Jan 7, 2025

Description

If RGB Matrix is enabled and RGB_MATRIX_DISABLE_SHARED_KEYCODES is defined, shifted is set but never used, causing unused variable errors.

Types of Changes

  • Core
  • Bugfix

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team January 7, 2025 19:09
@drashna @fauxpark
Update quantum/process_keycode/process_underglow.c
58c8875 
Co-authored-by: Ryan <fauxpark@gmail.com>
@drashna drashna merged commit 80c90a6 into qmk:master Jan 8, 2025
4 checks passed
@drashna drashna deleted the fix/rgb_codes branch January 8, 2025 16:50
MichaelScofield45 pushed a commit to MichaelScofield45/qmk_firmware that referenced this pull request Jan 8, 2025
@drashna @fauxpark @MichaelScofield45
[Bug] Fix Underglow keycode processing (qmk#24798)
90d1800 
Co-authored-by: Ryan <fauxpark@gmail.com>
mizma pushed a commit to mizma/qmk_firmware that referenced this pull request Jan 9, 2025
@drashna @fauxpark @mizma
[Bug] Fix Underglow keycode processing (qmk#24798)
d550c48 
Co-authored-by: Ryan <fauxpark@gmail.com>
milosbugarinovic pushed a commit to milosbugarinovic/qmk_firmware that referenced this pull request Jan 13, 2025
@drashna @fauxpark @milosbugarinovic
[Bug] Fix Underglow keycode processing (qmk#24798)
b1d121a 
Co-authored-by: Ryan <fauxpark@gmail.com>
gebolze pushed a commit to gebolze/qmk_firmware that referenced this pull request Jan 16, 2025
@drashna @fauxpark @gebolze
[Bug] Fix Underglow keycode processing (qmk#24798)
5662167 
Co-authored-by: Ryan <fauxpark@gmail.com>
pashashocky pushed a commit to pashashocky/qmk that referenced this pull request Jan 17, 2025
@drashna @fauxpark @pashashocky
[Bug] Fix Underglow keycode processing (qmk#24798)
6ca931b 
Co-authored-by: Ryan <fauxpark@gmail.com>
vinniefranco pushed a commit to Good-Great-Grand-Wonderful/qmk_firmware that referenced this pull request Jan 20, 2025
@drashna @fauxpark
[Bug] Fix Underglow keycode processing (qmk#24798)
e6f5c44 
Co-authored-by: Ryan <fauxpark@gmail.com>
fsecilia pushed a commit to fsecilia/qmk_firmware that referenced this pull request Jan 27, 2025
@drashna @fauxpark @fsecilia
[Bug] Fix Underglow keycode processing (qmk#24798)
74e7d0e 
Co-authored-by: Ryan <fauxpark@gmail.com>
alk-alyss added a commit to alk-alyss/qmk_firmware that referenced this pull request Jan 30, 2025
@alk-alyss
Merge branch 'master' of https://github.com/qmk/qmk_firmware
07d8f40 
* 'master' of https://github.com/qmk/qmk_firmware: (221 commits)
  Add Keychron C3 Pro (Red & RGB) (qmk#24874)
  [OS Detection] Improve MacOS detection (qmk#24708)
  Bump vite from 5.2.14 to 5.4.12 in /builddefs/docsgen (qmk#24852)
  Reject keyboard.json next to info.json (qmk#24882)
  Add keyboard clap_studio/flame60 (qmk#24870)
  [Keyboard] Add Support E8ghtyNeo (qmk#24859)
  [License Violation] add pressplayid (qmk#24869)
  Fix missing wait.h include in Dip Switch Map (qmk#24863)
  Add Model-B keyboard (qmk#24681)
  Updated Licence Violations for Chosfox L75 (qmk#24833)
  License violations updates. (qmk#24831)
  Add Lily (qmk#24813)
  `kikoslab/kl90`: fix keymap (qmk#24826)
  [Keyboard] Add ic45v2 (qmk#24818)
  Allow running Docker container on MacOS (without in-container USB support) (qmk#24412)
  `salane/ncr80alpsskfl`: add additional layouts (qmk#24809)
  Bump nanoid from 3.3.7 to 3.3.8 in /builddefs/docsgen (qmk#24713)
  Fix a build warning and tidy up a keymap (qmk#24805)
  [Bug] Fix Underglow keycode processing (qmk#24798)
  [Docs] Fix wording in Mod Tap documentation (qmk#24796)
  ...
Rumadon pushed a commit to Rumadon/qmk_firmware that referenced this pull request Jan 31, 2025
@drashna @fauxpark @Rumadon
[Bug] Fix Underglow keycode processing (qmk#24798)
aa6821e 
Co-authored-by: Ryan <fauxpark@gmail.com>
MaximumP pushed a commit to MaximumP/qmk_firmware that referenced this pull request Feb 1, 2025
@drashna @fauxpark
[Bug] Fix Underglow keycode processing (qmk#24798)
782d15b 
Co-authored-by: Ryan <fauxpark@gmail.com>
alinelena pushed a commit to alinelena/qmk_firmware that referenced this pull request Feb 3, 2025
@drashna @fauxpark @alinelena
[Bug] Fix Underglow keycode processing (qmk#24798)
ae8a7e1 
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] (Minor) Compiler warning when RGB_MATRIX_DISABLE_SHARED_KEYCODES and RGB_MATRIX_ENABLE are both defined
3 participants
@drashna @fauxpark @zvecr