[Keyboard] Add keyboard reviung46 #24245

gtips · 2024-08-05T11:38:49Z

Description

The REVIUNG46 is 42-46 key keyboard.

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/reviung/reviung46/keyboard.json

zvecr · 2024-08-05T12:28:05Z

keyboards/reviung/reviung46/readme.md

@@ -0,0 +1,27 @@
+# reviung46
+
+![reviung46](https://github.com/gtips/reviung/blob/master/reviung46/image/reviung46-01.jpg) 


Image here shows multiple layouts are capable, so there should probably be more than 1 defined in keyboard.json

Thanks.
I designed the PCB so that multiple key layouts can work with one layout keyboard.json.
I have confirmed that it works properly on the test board.
The PCB design is similar to REVIUNG53.
https://github.com/gtips/reviung/tree/master/reviung53

PCB data added.
Request review.
https://github.com/gtips/reviung/tree/master/reviung46

I designed the PCB so that multiple key layouts can work with one layout keyboard.json.

Incorrect. Your PCB clearly supports multiple layouts. The expectation is that you add multiple layout macros to support these.

Request review.

There is nothing to review as you have not implemented the extra layouts in keyboard.json.

I’m so sorry.
It was my lack of understanding.
The last time I made a keyboard was three years ago, so I mixed up the way I did it three years ago.

I've fixed keyboard.json so I'm requesting a review.

keyboards/reviung/reviung46/keyboard.json

waffle87 · 2024-08-05T22:18:12Z

keyboards/reviung/reviung46/keyboard.json

+    "processor": "atmega32u4",
+    "bootloader": "caterina",


Suggested change

"processor": "atmega32u4",

"bootloader": "caterina",

"development_board": "promicro",

Thanks.
I fixed it.

Doesn't appear so, did you forget to push this change?

I fixed it and pushed it.

The lines suggested for removal have not been removed. They are not needed when using development_board.

Thanks.
I fixed it.

I fixed it.
Request review.

keyboards/reviung/reviung46/keymaps/default/keymap.c

keyboards/reviung/reviung46/keymaps/via/keymap.c

keyboards/reviung/reviung46/keymaps/default/keymap.c

keyboards/reviung/reviung46/keymaps/via/keymap.c

fix keyboards/reviung/reviung46/keymaps/via/keymap.c

keyboards/reviung/reviung46/keyboard.json

gtips · 2024-08-20T11:02:42Z

modified keyboards/reviung/reviung46/readme.md

drashna

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

keyboards/reviung/reviung46/keymaps/default/keymap.c

deleted keyboards/reviung/reviung46/keymaps/via/keymap.c deleted keyboards/reviung/reviung46/keymaps/via/rules.mk

gtips · 2024-08-30T04:26:01Z

Thanks.
I removed the VIA keymap.

github-actions · 2024-10-15T02:03:40Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

fauxpark · 2024-10-15T03:13:46Z

keyboards/reviung/reviung46/keyboard.json

+            "knight": true,
+            "christmas": true,
+            "static_gradient": true,
+            "rgb_test": true,


Suggested change

"rgb_test": true,

Thanks.
I fixed it.

fauxpark · 2024-10-15T03:14:41Z

keyboards/reviung/reviung46/keymaps/default/keymap.c

+                          RGB_VAI,   RGB_SAI, RGB_HUI,  RGB_MOD,  XXXXXXX,  RGB_TOG,  XXXXXXX,  XXXXXXX,  XXXXXXX,  XXXXXXX,  XXXXXXX,  XXXXXXX,
+                          RGB_VAD,   RGB_SAD, RGB_HUD,  RGB_RMOD, XXXXXXX,  XXXXXXX,  XXXXXXX,  XXXXXXX,  XXXXXXX,  XXXXXXX,  XXXXXXX,  XXXXXXX,


Suggested change

RGB_VAI, RGB_SAI, RGB_HUI, RGB_MOD, XXXXXXX, RGB_TOG, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX,

RGB_VAD, RGB_SAD, RGB_HUD, RGB_RMOD, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX,

UG_VALU, UG_SATU, UG_HUEU, UG_NEXT, XXXXXXX, UG_TOGG, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX,

UG_VALD, UG_SATD, UG_HUED, UG_PREV, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX,

Thanks.
I fixed it.

…eviung46/keymaps/default/keymap.c

github-actions · 2024-12-01T02:16:46Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

keyboards/reviung/reviung46/readme.md

* add keyboard reviung46 * modified keyboards/reviung/reviung46/readme.md * modified keyboards/reviung/reviung46/keyboard.json * modified keyboards/reviung/reviung46/readme.md * fix keyboards/reviung/reviung46/keyboard.json * fix keyboards/reviung/reviung46/keymaps/default/keymap.c fix keyboards/reviung/reviung46/keymaps/via/keymap.c * fix keyboards/reviung/reviung46/keymaps/via/keymap.c * fix keyboards/reviung/reviung46/keyboard.json * fix keyboards/reviung/reviung46/keyboard.json * modified reviung/reviung46/readme.md * fixed keyboards/reviung/reviung46/keyboard.json * fixed keyboards/reviung/reviung46/keymaps/default/keymap.c deleted keyboards/reviung/reviung46/keymaps/via/keymap.c deleted keyboards/reviung/reviung46/keymaps/via/rules.mk * fix keyboards/reviung/reviung46/keyboard.json and keyboards/reviung/reviung46/keymaps/default/keymap.c * Update keyboards/reviung/reviung46/readme.md --------- Co-authored-by: jack <jack@pngu.org>

gtips added 4 commits July 17, 2024 15:41

add keyboard reviung46

bd8e7d2

modified keyboards/reviung/reviung46/readme.md

6418853

modified keyboards/reviung/reviung46/keyboard.json

511907b

modified keyboards/reviung/reviung46/readme.md

1118951

github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Aug 5, 2024

zvecr requested changes Aug 5, 2024

View reviewed changes

waffle87 requested changes Aug 5, 2024

View reviewed changes

fix keyboards/reviung/reviung46/keyboard.json

28954d0

waffle87 reviewed Aug 6, 2024

View reviewed changes

gtips added 2 commits August 6, 2024 11:24

fix keyboards/reviung/reviung46/keymaps/default/keymap.c

757f713

fix keyboards/reviung/reviung46/keymaps/via/keymap.c

fix keyboards/reviung/reviung46/keymaps/via/keymap.c

94b0614

gtips commented Aug 6, 2024

View reviewed changes

keyboards/reviung/reviung46/keyboard.json Show resolved Hide resolved

fix keyboards/reviung/reviung46/keyboard.json

64c4904

gtips requested review from waffle87 and zvecr August 7, 2024 01:03

gtips added 2 commits August 8, 2024 06:21

fix keyboards/reviung/reviung46/keyboard.json

e5c0cbd

modified reviung/reviung46/readme.md

b6645f6

github-actions bot added the keyboard label Aug 20, 2024

fixed keyboards/reviung/reviung46/keyboard.json

8879983

drashna requested changes Aug 30, 2024

View reviewed changes

fixed keyboards/reviung/reviung46/keymaps/default/keymap.c

2b77cfb

deleted keyboards/reviung/reviung46/keymaps/via/keymap.c deleted keyboards/reviung/reviung46/keymaps/via/rules.mk

drashna approved these changes Aug 30, 2024

View reviewed changes

drashna requested a review from a team August 30, 2024 05:03

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 15, 2024

fauxpark requested changes Oct 15, 2024

View reviewed changes

fix keyboards/reviung/reviung46/keyboard.json and keyboards/reviung/r…

85fcac4

…eviung46/keymaps/default/keymap.c

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Oct 17, 2024

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 1, 2024

waffle87 reviewed Dec 3, 2024

View reviewed changes

keyboards/reviung/reviung46/readme.md Outdated Show resolved Hide resolved

Update keyboards/reviung/reviung46/readme.md

f2353b0

waffle87 approved these changes Dec 3, 2024

View reviewed changes

waffle87 merged commit c5eeac9 into qmk:master Dec 3, 2024
2 of 3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Keyboard] Add keyboard reviung46 #24245

[Keyboard] Add keyboard reviung46 #24245

gtips commented Aug 5, 2024

zvecr Aug 5, 2024

gtips Aug 6, 2024

gtips Aug 21, 2024

zvecr Aug 21, 2024 •

edited

Loading

gtips Aug 21, 2024

waffle87 Aug 5, 2024

gtips Aug 6, 2024

waffle87 Aug 6, 2024

gtips Aug 6, 2024 •

edited

Loading

waffle87 Aug 7, 2024

gtips Aug 7, 2024

gtips Aug 21, 2024

gtips commented Aug 20, 2024

drashna left a comment

gtips commented Aug 30, 2024

github-actions bot commented Oct 15, 2024

fauxpark Oct 15, 2024

gtips Oct 16, 2024

fauxpark Oct 15, 2024

gtips Oct 16, 2024

github-actions bot commented Dec 1, 2024

		@@ -0,0 +1,27 @@
		# reviung46

		![reviung46](https://github.com/gtips/reviung/blob/master/reviung46/image/reviung46-01.jpg)

	"processor": "atmega32u4",
	"bootloader": "caterina",
	"development_board": "promicro",

		RGB_VAI, RGB_SAI, RGB_HUI, RGB_MOD, XXXXXXX, RGB_TOG, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX,
		RGB_VAD, RGB_SAD, RGB_HUD, RGB_RMOD, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX,

[Keyboard] Add keyboard reviung46 #24245

[Keyboard] Add keyboard reviung46 #24245

Conversation

gtips commented Aug 5, 2024

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zvecr Aug 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gtips Aug 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gtips commented Aug 20, 2024

drashna left a comment

Choose a reason for hiding this comment

gtips commented Aug 30, 2024

github-actions bot commented Oct 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 1, 2024

zvecr Aug 21, 2024 •

edited

Loading

gtips Aug 6, 2024 •

edited

Loading