Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds keyboard "Sofle Pico" #23338

Open
wants to merge 95 commits into
base: master
Choose a base branch
from
Open

Adds keyboard "Sofle Pico" #23338

wants to merge 95 commits into from

Conversation

JellyTitan
Copy link
Contributor

Adds a variant of the Sofle designed specifically for the RP2040, and includes new features not found in the legacy Sofle family. (Specifically the 128x64 OLED)

It is different enough from the legacy sofle to warrant it's own directory, like the sofle_choc has:
image

The hardware & QMK build has been tested by contributors.

The documentation can be found here: https://www.soflepico.com/

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Removed Deluxe keymap from Junco
Based on the sofle_choc Brian Low default
Added search 'tags'
added comma after mouse config in json
It was redundant because it uses default transport I2C
Validated this is working as expected
Updated attribution comments
Updated Sofle Pico OLED logo
Added Sofle Pico OLED attributation and build data
Copy link
Contributor Author

@JellyTitan JellyTitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review! I've made the recommended changes.

Copy link
Member

@waffle87 waffle87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also marked a suggestion as unresolved above that wasn't addressed.

keyboards/sofle_pico/info.json Outdated Show resolved Hide resolved
keyboards/sofle_pico/sofle_pico.c Outdated Show resolved Hide resolved
@waffle87 waffle87 requested a review from a team April 8, 2024 23:19
JellyTitan and others added 2 commits April 8, 2024 16:26
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: jack <0x6a73@protonmail.com>
@JellyTitan JellyTitan requested a review from waffle87 April 8, 2024 23:31
Copy link
Contributor Author

@JellyTitan JellyTitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waffle87 Thank you for the re-review! I've made that changes you recommended. I apologize for missing those on the first pass, that was sloppy of me.

Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label May 24, 2024
@JellyTitan
Copy link
Contributor Author

@drashna & @waffle87 Thank you for the reviews - I've made the requested changes. Are there any other fixes needed?

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label May 25, 2024
@JellyTitan
Copy link
Contributor Author

Updated to latest QMK release.

@drashna drashna requested a review from a team July 14, 2024 06:43
@tzarc
Copy link
Member

tzarc commented Aug 26, 2024

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 11, 2024
@JellyTitan
Copy link
Contributor Author

VIA keymaps removed and ready for review

keyboards/sofle_pico/rules.mk Outdated Show resolved Hide resolved
keyboards/sofle_pico/info.json Show resolved Hide resolved
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Oct 17, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be renamed to keyboard.json.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like RGB Matrix is enabled but there are no keycodes to do anything with it?

Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution. via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants