-
-
Notifications
You must be signed in to change notification settings - Fork 40.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds keyboard "Sofle Pico" #23338
base: master
Are you sure you want to change the base?
Adds keyboard "Sofle Pico" #23338
Conversation
Removed Deluxe keymap from Junco
Based on the sofle_choc Brian Low default
bumped version
Added search 'tags' added comma after mouse config in json
Removed bootmagic
It was redundant because it uses default transport I2C
Validated this is working as expected
Updated attribution comments
Updated Sofle Pico OLED logo Added Sofle Pico OLED attributation and build data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review! I've made the recommended changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also marked a suggestion as unresolved above that wasn't addressed.
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: jack <0x6a73@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@waffle87 Thank you for the re-review! I've made that changes you recommended. I apologize for missing those on the first pass, that was sloppy of me.
Thank you for your contribution! |
Updated to latest QMK release. |
As of August 26, 2024, As you've submitted a PR containing |
Thank you for your contribution! |
VIA keymaps removed and ready for review |
serial driver moving to json config
Co-authored-by: Joel Challis <git@zvecr.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be renamed to keyboard.json
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like RGB Matrix is enabled but there are no keycodes to do anything with it?
Thank you for your contribution! |
Adds a variant of the Sofle designed specifically for the RP2040, and includes new features not found in the legacy Sofle family. (Specifically the 128x64 OLED)
It is different enough from the legacy sofle to warrant it's own directory, like the sofle_choc has:
![image](https://private-user-images.githubusercontent.com/72168556/316337906-c1e6899f-cb3a-4b1c-8199-f0a9ea3856fa.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MzQ4MzAsIm5iZiI6MTczOTQzNDUzMCwicGF0aCI6Ii83MjE2ODU1Ni8zMTYzMzc5MDYtYzFlNjg5OWYtY2IzYS00YjFjLTgxOTktZjBhOWVhMzg1NmZhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDA4MTUzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA5NjMyYzY0NWE2YWM2ZWQ2YmVjYTE4YTlkMWQ2MWRlNTA2MGM1NGI0NmQ1OTk2YTRmY2Y4NWVmMzI0NzE3MTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ujMI2PQ5aHrHtZrv5UumjOPJjQPvlgoajrC4v2O6Aks)
The hardware & QMK build has been tested by contributors.
The documentation can be found here: https://www.soflepico.com/
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist